Re: netfilter: nf_tables: add reject module for NFPROTO_INET

[Patrick McHardy <kaber@trash.net>]

On Wed, Feb 12, 2014 at 09:18:27AM -0500, Dave Jones wrote:
> On Tue, Feb 11, 2014 at 08:33:59PM +0000, Linux Kernel wrote:
>  > Gitweb:     http://git.kernel.org/linus/;a=commit;h=05513e9e33dbded8124567466a444d32173eecc6
>  > Commit:     05513e9e33dbded8124567466a444d32173eecc6
>  > Parent:     cc4723ca316742891954efa346298e7c747c0d17
>  > Author:     Patrick McHardy <kaber@trash.net>
>  > AuthorDate: Wed Feb 5 15:03:39 2014 +0000
>  > Committer:  Pablo Neira Ayuso <pablo@netfilter.org>
>  > CommitDate: Thu Feb 6 09:44:18 2014 +0100
>  > 
>  >     netfilter: nf_tables: add reject module for NFPROTO_INET
>  >     
>  >     Add a reject module for NFPROTO_INET. It does nothing but dispatch
>  >     to the AF-specific modules based on the hook family.
>  >     
>  >     Signed-off-by: Patrick McHardy <kaber@trash.net>
>  >     Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>  > ---
> 
> ....
> 
>  > +static void nft_reject_inet_eval(const struct nft_expr *expr,
>  > +				 struct nft_data data[NFT_REG_MAX + 1],
>  > +				 const struct nft_pktinfo *pkt)
>  > +{
>  > +	switch (pkt->ops->pf) {
>  > +	case NFPROTO_IPV4:
>  > +		nft_reject_ipv4_eval(expr, data, pkt);
>  > +	case NFPROTO_IPV6:
>  > +		nft_reject_ipv6_eval(expr, data, pkt);
>  > +	}
>  > +}
> 
> Is the fallthrough intentional here, or is there a missing break ?

Crap. Thanks for catching this, I'll send a fix later.