From: Tejun Heo <tj@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: linux-next: build failure after merge of the final tree (cgroup tree related)
Date: Wed, 12 Feb 2014 16:15:38 -0500 [thread overview]
Message-ID: <20140212211538.GG26809@htj.dyndns.org> (raw)
In-Reply-To: <20140212162500.242e91e4cc3541b992fa3a0c@canb.auug.org.au>
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq':
> arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from integer without a cast [-Werror]
>
> Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> missing slab.h includes")). I wonder how mane more builds are broken by
> this :-(
>
> Indeed, reverting that commit fixes the build.
>
> I have added the following build fix for today (please check the
> overnight builds for more breakage):
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 12 Feb 2014 16:01:10 +1100
> Subject: [PATCH] sun4M: add include of slab.h for kzalloc
>
> This was being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Applied to cgroup/for-3.15.
Thanks!
--
tejun
next prev parent reply other threads:[~2014-02-12 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 5:25 linux-next: build failure after merge of the final tree (cgroup tree related) Stephen Rothwell
2014-02-12 6:39 ` Tejun Heo
2014-02-12 10:47 ` Stephen Rothwell
2014-02-12 14:27 ` Tejun Heo
2014-02-12 20:36 ` Sam Ravnborg
2014-02-12 21:15 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-13 5:12 Stephen Rothwell
2013-03-13 6:33 ` Li Zefan
2013-03-13 6:33 ` Li Zefan
2013-03-20 4:43 ` Stephen Rothwell
2013-03-20 4:43 ` Stephen Rothwell
2013-03-20 14:51 ` Tejun Heo
2013-03-20 22:09 ` Stephen Rothwell
2013-03-20 22:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212211538.GG26809@htj.dyndns.org \
--to=tj@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.