From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Chew <AChew@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
"wim@iguana.be" <wim@iguana.be>,
"rob@landley.net" <rob@landley.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"abrestic@chromium.org" <abrestic@chromium.org>,
"dgreid@chromium.org" <dgreid@chromium.org>,
"katierh@chromium.org" <katierh@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v5 1/1] watchdog: Add tegra watchdog
Date: Wed, 12 Feb 2014 13:49:56 -0800 [thread overview]
Message-ID: <20140212214956.GA30463@roeck-us.net> (raw)
In-Reply-To: <643E69AA4436674C8F39DCC2C05F76386319AB3891@HQMAIL03.nvidia.com>
On Wed, Feb 12, 2014 at 01:43:37PM -0800, Andrew Chew wrote:
> > > +static void tegra_wdt_unref(struct watchdog_device *wdd) {
> > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd);
> > > +
> > > + kref_put(&wdt->kref, tegra_wdt_release_resources); }
> >
> > I forget why these were needed; they seem to do nothing.
>
> The reason I did the whole kref thing was by following the guidance
> in Documentation/watchdog/watchdog-kernel-api.txt, which says
> that if the watchdog_device struct is dynamically allocated, then
> one needs this.
>
I read that too, but I could not follow the logic behind it,
nor the explanation provided with the commit introducing it ;-)
Guenter
prev parent reply other threads:[~2014-02-12 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 1:54 [PATCH v5 1/1] watchdog: Add tegra watchdog Andrew Chew
2014-02-07 1:54 ` Andrew Chew
[not found] ` <1391738086-29142-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07 1:57 ` Guenter Roeck
2014-02-07 1:57 ` Guenter Roeck
2014-02-11 22:11 ` Andrew Chew
2014-02-12 18:52 ` Stephen Warren
2014-02-12 21:43 ` Andrew Chew
2014-02-12 21:49 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212214956.GA30463@roeck-us.net \
--to=linux@roeck-us.net \
--cc=AChew@nvidia.com \
--cc=abrestic@chromium.org \
--cc=dgreid@chromium.org \
--cc=grant.likely@linaro.org \
--cc=katierh@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.