From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravind Gopalakrishnan Subject: Re: [PATCH 2/2 V2] mcheck, vmce: Allow vmce_amd_* functions to handle AMD thresolding MSRs Date: Wed, 12 Feb 2014 17:43:13 -0600 Message-ID: <20140212234312.GA30754@arav-dinar> References: <52E7A17D020000780011784E@nat28.tlf.novell.com> <52F2A1E4.9030700@amd.com> <52F35EE60200007800119A84@nat28.tlf.novell.com> <52FB409A.3010506@amazon.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52FB409A.3010506@amazon.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Egger, Christoph" Cc: "jinsong.liu@intel.com" , "boris.ostrovsky@oracle.com" , "Suthikulpanit, Suravee" , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Feb 12, 2014 at 03:36:26AM -0600, Egger, Christoph wrote: > On 06.02.14 10:07, Jan Beulich wrote: > >>>> On 05.02.14 at 21:41, Aravind Gopalakrishnan > > wrote: > >> On 1/28/2014 5:24 AM, Jan Beulich wrote: > >>>>>> On 27.01.14 at 23:44, Aravind Gopalakrishnan > >> wrote: > > > > No - bit 4 is part of what forms the bank number. Hence it must > > be masked out in the switch() expression. > > I prefer to see a comment in the code that makes this clear. > Agreed, I have added very brief comments in the code. Do let me know if it needs to be more verbose.. Thanks, -Aravind.