From: Daniel Gollub <daniel.gollub@t-online.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: fio@vger.kernel.org, Daniel Gollub <d.gollub@telekom.de>
Subject: Re: [PATCH 2/2] engines/null: allow build as external C++ ioengine
Date: Thu, 13 Feb 2014 07:25:00 +0100 [thread overview]
Message-ID: <20140213072500.792e7a92@marvin> (raw)
In-Reply-To: <52FC465A.4060009@kernel.dk>
On Wed, 12 Feb 2014 21:13:14 -0700, Jens Axboe wrote:
> On 2014-02-12 12:13, Daniel Gollub wrote:
> > In first place to have a simple test candidate for external
> > ioengines using get_ioengine() method for retriving the
> > io_engine struct.
> >
> > Can be compiled with:
> >
> > g++ -O2 -g -shared -rdynamic -fPIC -o null.so null.c
> > -DFIO_EXTERNAL_ENGINE
>
> I'm assuming this is just an example of how you'd build your external
> engine? Look OK to me with that in mind.
>
Yes it is. I although thought about integrating the build (of the null
C++/external variant) as kind of a build/compile test (not by default)
so we can spot changes on fio.h (or headers which are included by fio.h)
which break builds for external C++ based ioengines.
Something like ./configure --example-external-ioengines which
would also build skeleton_external (plain C) and cpp_null.so (if g++ is
available).
--
Daniel Gollub
next prev parent reply other threads:[~2014-02-13 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 19:13 [PATCH 1/2] Introduce get_ioengine for external engines Daniel Gollub
2014-02-12 19:13 ` [PATCH 2/2] engines/null: allow build as external C++ ioengine Daniel Gollub
2014-02-13 4:13 ` Jens Axboe
2014-02-13 6:25 ` Daniel Gollub [this message]
2014-02-13 4:12 ` [PATCH 1/2] Introduce get_ioengine for external engines Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213072500.792e7a92@marvin \
--to=daniel.gollub@t-online.de \
--cc=axboe@kernel.dk \
--cc=d.gollub@telekom.de \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.