From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 13 Feb 2014 11:33:13 +0000 Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Message-Id: <20140213113313.GL32508@lee--X1> List-Id: References: <1392281438-31836-1-git-send-email-lpapp@kde.org> <20140213095817.GD32508@lee--X1> <20140213111530.2a2b4982@endymion.delvare> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laszlo Papp Cc: Jean Delvare , LKML , lm-sensors@lm-sensors.org, Guenter Roeck PiA+Pj4gPiAtc3RhdGljIGludCBtYXg2NjUwX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll bnQsCj4gPj4+ID4gLSAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGkyY19kZXZpY2Vf aWQgKmlkKTsKPiA+Pj4gPiAtc3RhdGljIGludCBtYXg2NjUwX2luaXRfY2xpZW50KHN0cnVjdCBp MmNfY2xpZW50ICpjbGllbnQpOwo+ID4+PiA+IC1zdGF0aWMgaW50IG1heDY2NTBfcmVtb3ZlKHN0 cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpOwo+ID4+PiA+ICtzdGF0aWMgaW50IG1heDY2NTBfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldik7Cj4gPj4+ID4gK3N0YXRpYyBpbnQgbWF4 NjY1MF9pbml0X2NsaWVudChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KTsKPiA+Pj4gPiAr c3RhdGljIGludCBtYXg2NjUwX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KTsK PiA+Pj4gPiAgc3RhdGljIHN0cnVjdCBtYXg2NjUwX2RhdGEgKm1heDY2NTBfdXBkYXRlX2Rldmlj ZShzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+ID4+Pgo+ID4+PiBJdCB3b3VsZCBiZSBnb29kIHRvIHJl bW92ZSB0aGVzZSBmb3J3YXJkIGRlY2xhcmF0aW9ucyBpbiB0aGUgZnV0dXJlLgo+ID4+Pgo+ID4+ PiBJZiBubyBvbmUgdm9sdW50ZWVycyBJJ2xsIGhhcHBpbHkgZG8gaXQuCj4gPj4KPiA+PiBHdWVu dGVyIGp1c3QgZGlkOgo+ID4+Cj4gPj4gaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL3BpcGVy bWFpbC9sbS1zZW5zb3JzLzIwMTQtRmVicnVhcnkvMDQxMjI0Lmh0bWwKPiA+Pgo+ID4+IEFueSBj aGFuZ2UgdG8gdGhlIG1heDY2NTAgZHJpdmVyIHNob3VsZCBnbyBvbiB0b3Agb2YgaGlzIHBhdGNo IHNlcmllcwo+ID4+IHRvIGF2b2lkIGNvbmZsaWN0czoKPiA+Pgo+ID4+IGh0dHA6Ly9saXN0cy5s bS1zZW5zb3JzLm9yZy9waXBlcm1haWwvbG0tc2Vuc29ycy8yMDE0LUZlYnJ1YXJ5LzA0MTIyMy5o dG1sCj4gPgo+IEFzIGZhciBhcyBJIGNhbiBzZWUsIHRoYXQgcGF0Y2ggc2V0IHdhcyBub3QgZXZl biB0ZXN0ZWQsIHNvIGhvdyBjYW4gaXQKPiBnbyBpbj8gSSB3YXMgdG9sZCB0aGF0IGFueSBwYXRj aCBzaG91bGQgYmUgX3J1bnRpbWVfIHRlc3RlZCwgdG9vLgo+IEZ3aXcsIEkgZG8gbm90IGhhdmUg dGltZSB0byB0ZXN0IHRob3NlIHBlcnNvbmFsbHksIGhlIHdvdWxkIG5lZWQgdG8KPiBmaW5kIHNv bWVvbmUgZWxzZSBpZiB0aGF0IHJlcXVpcmVtZW50IHJlYWxseSBob2xkcyB0cnVlLgo+Cj4gSSB3 b3VsZCBub3QgcmVhbGx5IGxpa2UgdG8gZml4IGJ1Z3MgYXBwZWFyaW5nIGluIHRoYXQgY29kZSB0 byBnZXQgbXkKPiBmZWF0dXJlcyBpbi4KPiAKPiBBbHNvLCBzaW5jZSBteSBjaGFuZ2UgaGFzIGJl ZW4gYXJvdW5kIGZvciAyLTMgbW9udGhzIG5vdywgSSB3b3VsZAo+IHJlYWxseSBwcmVmZXIgbm90 IHRvIGJlIGZvcmNlZCB0byByZXdyaXRlIGl0IGFnYWluIGZyb20gc2NyYXRjaC4KPiBTdXJlbHks IHlvdSBjYW4gd2FpdCB3aXRoIHRob3NlLCBtb3JlIG9yIGxlc3MsIGNvc21ldGljIG5vbi1ydW50 aW1lCj4gdGVzdGVkIGNoYW5nZXM/Cj4gCj4gVGhpcyB3b3VsZCBpbXBvc2UgbWUgYSBsb3Qgb2Yg YWRkaXRpb25hbCB3b3JrIGFnYWluLCBhbmQgSSBwZXJzb25hbGx5Cj4gZG8gbm90IHNlZSB0aGUg YmVuZWZpdCBvZiBpdC4gSW4gbXkgYm9vayBhdCBsZWFzdCwgZmVhdHVyZSBpcyBvdmVyCj4gaW50 ZXJuYWwgcG9saXNoaW5nLgoKUmlnaHQsIEkndmUgaGFkIGVub3VnaC4gSSdtIHJlbW92aW5nIHlv dXIgcGF0Y2ggZnJvbSB0aGUgTUZEIHRyZWUuCgpJJ3ZlIGFza2VkIHRvbyBtYW55IHBlb3BsZSB0 byBnaXZlIHlvdSBhIHNlY29uZCBjaGFuY2UgYW5kIGFza2VkIHlvdQpwcml2YXRlbHkgdG8gYmVo YXZlIHlvdXJzZWxmIGFuZCB0cmVhdCBvdGhlcnMgd2l0aCByZXNwZWN0LiBTbyBmYXIgSQpoYXZl bid0IHNlZW4gYW4gb3VuY2Ugb2Ygc2VsZiBjb250cm9sIG9yIGRlcG9tYWN5IGZyb20geW91LgoK VGhpcyBpcyBob3cgaXQncyBnb2luZyB0byB3b3JrIGZyb20gbm93IG9uOgoKIC0gWW91IHN1Ym1p dCBhIHBhdGNoCiAtIEl0IGdldHMgcmV2aWV3ZWQgICAgICAgICAgICAgICAgICAgICAgICAgICAg PC0tLS1cCiAtIFlvdSBmaXggdXAgdGhlIHJldmlldyBjb21tZW50cyBhcyByZXF1ZXN0ZWQgLS0t LS0vCiAtIE5vbi1jb21wbGlhbmNlIG9yIGFyZ3VtZW50cyB3aXRoIHRoZSBfZXhwZXJ0c18gcmVz dWx0cyBpbjoKICAgIGAkSU5URVJFU1QgPiAvZGV2L251bGwgfHwgXAogICAgICBncmVwICJGcm9t OiBMYXN6aW8gUGFwcCIgfi8ubWFpbCB8IHhhcmdzIHJtIC1yZmAKCi0tIApMZWUgSm9uZXMKTGlu YXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBP cGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sg fCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9y ZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbaBMLdV (ORCPT ); Thu, 13 Feb 2014 06:33:21 -0500 Received: from mail-we0-f176.google.com ([74.125.82.176]:51882 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbaBMLdT (ORCPT ); Thu, 13 Feb 2014 06:33:19 -0500 Date: Thu, 13 Feb 2014 11:33:13 +0000 From: Lee Jones To: Laszlo Papp Cc: Jean Delvare , LKML , lm-sensors@lm-sensors.org, Guenter Roeck Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Message-ID: <20140213113313.GL32508@lee--X1> References: <1392281438-31836-1-git-send-email-lpapp@kde.org> <20140213095817.GD32508@lee--X1> <20140213111530.2a2b4982@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>> > -static int max6650_probe(struct i2c_client *client, > >>> > - const struct i2c_device_id *id); > >>> > -static int max6650_init_client(struct i2c_client *client); > >>> > -static int max6650_remove(struct i2c_client *client); > >>> > +static int max6650_probe(struct platform_device *pdev); > >>> > +static int max6650_init_client(struct platform_device *pdev); > >>> > +static int max6650_remove(struct platform_device *pdev); > >>> > static struct max6650_data *max6650_update_device(struct device *dev); > >>> > >>> It would be good to remove these forward declarations in the future. > >>> > >>> If no one volunteers I'll happily do it. > >> > >> Guenter just did: > >> > >> http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html > >> > >> Any change to the max6650 driver should go on top of his patch series > >> to avoid conflicts: > >> > >> http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041223.html > > > As far as I can see, that patch set was not even tested, so how can it > go in? I was told that any patch should be _runtime_ tested, too. > Fwiw, I do not have time to test those personally, he would need to > find someone else if that requirement really holds true. > > I would not really like to fix bugs appearing in that code to get my > features in. > > Also, since my change has been around for 2-3 months now, I would > really prefer not to be forced to rewrite it again from scratch. > Surely, you can wait with those, more or less, cosmetic non-runtime > tested changes? > > This would impose me a lot of additional work again, and I personally > do not see the benefit of it. In my book at least, feature is over > internal polishing. Right, I've had enough. I'm removing your patch from the MFD tree. I've asked too many people to give you a second chance and asked you privately to behave yourself and treat others with respect. So far I haven't seen an ounce of self control or depomacy from you. This is how it's going to work from now on: - You submit a patch - It gets reviewed <----\ - You fix up the review comments as requested -----/ - Non-compliance or arguments with the _experts_ results in: `$INTEREST > /dev/null || \ grep "From: Laszio Papp" ~/.mail | xargs rm -rf` -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog