From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ipset] kernel: uapi: fix MARKMASK attr ABI breakage
Date: Thu, 13 Feb 2014 12:47:25 +0100 [thread overview]
Message-ID: <20140213114725.GA8016@localhost> (raw)
In-Reply-To: <1392291659-27444-1-git-send-email-fw@strlen.de>
On Thu, Feb 13, 2014 at 12:40:59PM +0100, Florian Westphal wrote:
> commit 2dfb973c0dcc6d2211 (add markmask for hash:ip,mark data type)
I don't find that commit in the tree:
$ git show 2dfb973c0dcc6d2211
fatal: ambiguous argument '2dfb973c0dcc6d2211': unknown revision or
path not in the working tree.
Use '--' to separate paths from revisions
> inserted IPSET_ATTR_MARKMASK in-between other enum values, i.e.
> changing values of all further attributes. This causes 'ipset list'
> segfault on existing kernels since ipset no longer finds
> IPSET_ATTR_MEMSIZE (it has a different value on kernel side).
>
> Jozsef points out it should be moved below IPSET_ATTR_MARK which
> works since there is some extra reserved space after that value.
next prev parent reply other threads:[~2014-02-13 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 11:40 [PATCH ipset] kernel: uapi: fix MARKMASK attr ABI breakage Florian Westphal
2014-02-13 11:47 ` Pablo Neira Ayuso [this message]
2014-02-13 11:51 ` Florian Westphal
2014-02-13 11:55 ` Pablo Neira Ayuso
2014-02-13 12:13 ` Jozsef Kadlecsik
2014-02-13 12:54 ` Pablo Neira Ayuso
2014-02-14 8:23 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213114725.GA8016@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.