From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbaBMEYj (ORCPT ); Wed, 12 Feb 2014 23:24:39 -0500 Received: from m12-15.163.com ([220.181.12.15]:43649 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbaBMEYh (ORCPT ); Wed, 12 Feb 2014 23:24:37 -0500 Date: Thu, 13 Feb 2014 12:23:44 +0800 From: "liujunliang_ljl" To: "Thierry Reding" Cc: "davem" , "horms" , "joe" , "romieu" , "gregkh" , "netdev" , "linux-usb" , "linux-kernel" , "sunhecheng" References: <1392010419-5217-1-git-send-email-liujunliang_ljl@163.com> Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support Message-ID: <201402131223440786692@163.com> X-mailer: Foxmail 6, 15, 201, 22 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" X-CM-TRANSID: D8CowEBZW23MSPxSvQ7uAg--.492S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxCF1rKFW5Cr1kWw1rXr4kXrb_yoW5Xr4fpw 42yrW3Cr47tr13t34fJw18ZFy5AFs7tr98Kry3uasYvFW5ury5tw1j9Fy0gr17JrZ5Ca4j vFsI9a47Wa15WwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j4oGdUUUUU= X-Originating-IP: [113.110.151.25] X-CM-SenderInfo: xolxy3pqolt0hjboyzi6rwjhhfrp/xtbB0w4xX1EAI4TYIAAAs9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s1D4OhmO024812 Dear Thierry : For this driver, we can set it as 'n', and There is no rule of thumb as to which should default to y. Thanks for your advice. Thanks again. 2014-02-13 liujunliang_ljl 发件人： Thierry Reding 发送时间： 2014-02-12 18:12:52 收件人： liujunliang_ljl 抄送： davem; horms; joe; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng 主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support On Mon, Feb 10, 2014 at 01:33:39PM +0800, liujunliang_ljl@163.com wrote: > From: Liu Junliang > > > Signed-off-by: Liu Junliang > --- > drivers/net/usb/Kconfig | 16 + > drivers/net/usb/Makefile | 1 + > drivers/net/usb/sr9800.c | 873 ++++++++++++++++++++++++++++++++++++++++++++++ > drivers/net/usb/sr9800.h | 202 +++++++++++ > 4 files changed, 1092 insertions(+), 0 deletions(-) > create mode 100644 drivers/net/usb/sr9800.c > create mode 100644 drivers/net/usb/sr9800.h > > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig > index 47b0f73..2551bf6 100644 > --- a/drivers/net/usb/Kconfig > +++ b/drivers/net/usb/Kconfig > @@ -291,6 +291,22 @@ config USB_NET_SR9700 > This option adds support for CoreChip-sz SR9700 based USB 1.1 > 10/100 Ethernet adapters. > > +config USB_NET_SR9800 > + tristate "CoreChip-sz SR9800 based USB 2.0 10/100 ethernet devices" > + depends on USB_USBNET > + select CRC32 > + default y Why is this selected by default? I can see that some of the other USB network drivers are also selected by default, but not all of them. Is there some rule of thumb as to which should default to y and which shouldn't? Thierry -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJS+0kdAAoJEN0jrNd/PrOhXvwQAJIW4vgv0NkyQVo5jSvzeLY4 9PFCrtd6N1n+O7P99x38JCCD9lWtfdin1EZfj+UicCanup2WzpyBWHeBhdSN4oZA /+C+TgEIuX0+Be11IXeUOGMP9a3k/12HY3oHuz7BA2JjcK6PnfMxaEC7iGGJSjgz q4Goa5kSqjvNgbP8h5bQPTNtMnRdsSytI7PMJbl4t1ho0V7H3pSo9zD7rxaPhmtE v/18VQawGcY83Hr0B0Q18XAnNXaQMLZTvdhVfDUxB5VKT4Xhcri0m4adbAzMI9kR K9CEChkDn68y13drJVILKqUjW+4LMQHAsQV07yl98Sqk7LYOedL9mQOnIL0crjWa OAmLHwLv0ED25W1Hv3UdeSpBdIkO9cD0PCa7vHQnv7lpTlkaDyYelKLQ2D+GXrCw 1L/341ak9QEGiCU1TiOHDblnsN+OtCt0Pt+hijLHFl4TQKw3QIUoZLa4bQuDPM8M juTSV63HRjiDlNGvtjBezlR9GFu5w3SJuNSNsFkZ7ADJwjz9On9JaDwH/Ad7AqmZ ylE+zzbIpOWjyNToMH2dattpeVZkIfGkS02y6PcIx51EGMw5B8l6qKLB9YpkJpwR 7rhMYjpLKIn/6rRGlwmZKYnWYl7p/FdI0yOnVbtMYx406ivUNc+kgvmx5l1mXhT7 b8gKKYYA0pMEMXjgnkK1 =3y7X -----END PGP SIGNATURE----- 翳簕.n+壏煯壄+%娝遍荻w簕.n+壏{炳G珴妠ay蕠跈,jf＂穐殢飦戧鐉_璁(殠娸"濟mG珴⒏?櫒璀&ｘ忈秈O曟瑉窔v豝m 鹅⒏?朓 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "liujunliang_ljl" Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support Date: Thu, 13 Feb 2014 12:23:44 +0800 Message-ID: <201402131223440786692@163.com> References: <1392010419-5217-1-git-send-email-liujunliang_ljl@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Cc: "davem" , "horms" , "joe" , "romieu" , "gregkh" , "netdev" , "linux-usb" , "linux-kernel" , "sunhecheng" To: "Thierry Reding" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RGVhciBUaGllcnJ5IDoNCg0KCQkJRm9yIHRoaXMgZHJpdmVyLCB3ZSBjYW4gc2V0IGl0IGFzICdu JywgYW5kIFRoZXJlIGlzIG5vIHJ1bGUgb2YgdGh1bWIgYXMgdG8gd2hpY2ggc2hvdWxkIGRlZmF1 bHQgdG8geS4NCg0KCQkJVGhhbmtzIGZvciB5b3VyIGFkdmljZS4NCg0KCQkJVGhhbmtzIGFnYWlu Lg0KCQkNCg0KDQoyMDE0LTAyLTEzIA0KDQoNCg0KbGl1anVubGlhbmdfbGpsIA0KDQoNCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICANCreivP7Iy6O6IFRoaWVycnkgUmVkaW5nIA0Kt6LLzcqxvOSjuiAy MDE0LTAyLTEyICAxODoxMjo1MiANCsrVvP7Iy6O6IGxpdWp1bmxpYW5nX2xqbCANCrOty82juiBk YXZlbTsgaG9ybXM7IGpvZTsgcm9taWV1OyBncmVna2g7IG5ldGRldjsgbGludXgtdXNiOyBsaW51 eC1rZXJuZWw7IHN1bmhlY2hlbmcgDQrW98zio7ogUmU6IFtQQVRDSF0gVVNCMk5FVCA6IFNSOTgw MCA6IE9uZSBjaGlwIFVTQjIuMCBVU0IyTkVUIFNSOTgwMCBEZXZpY2VEcml2ZXIgU3VwcG9ydCAN CiANCk9uIE1vbiwgRmViIDEwLCAyMDE0IGF0IDAxOjMzOjM5UE0gKzA4MDAsIGxpdWp1bmxpYW5n X2xqbEAxNjMuY29tIHdyb3RlOg0KPiBGcm9tOiBMaXUgSnVubGlhbmcgPGxpdWp1bmxpYW5nX2xq bEAxNjMuY29tPg0KPiANCj4gDQo+IFNpZ25lZC1vZmYtYnk6IExpdSBKdW5saWFuZyA8bGl1anVu bGlhbmdfbGpsQDE2My5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvdXNiL0tjb25maWcgIHwg ICAxNiArDQo+ICBkcml2ZXJzL25ldC91c2IvTWFrZWZpbGUgfCAgICAxICsNCj4gIGRyaXZlcnMv bmV0L3VzYi9zcjk4MDAuYyB8ICA4NzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKw0KPiAgZHJpdmVycy9uZXQvdXNiL3NyOTgwMC5oIHwgIDIwMiArKysrKysr KysrKw0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxMDkyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25z KC0pDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9uZXQvdXNiL3NyOTgwMC5jDQo+ICBj cmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9uZXQvdXNiL3NyOTgwMC5oDQo+IA0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9uZXQvdXNiL0tjb25maWcgYi9kcml2ZXJzL25ldC91c2IvS2NvbmZpZw0K PiBpbmRleCA0N2IwZjczLi4yNTUxYmY2IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL25ldC91c2Iv S2NvbmZpZw0KPiArKysgYi9kcml2ZXJzL25ldC91c2IvS2NvbmZpZw0KPiBAQCAtMjkxLDYgKzI5 MSwyMiBAQCBjb25maWcgVVNCX05FVF9TUjk3MDANCj4gICAgIFRoaXMgb3B0aW9uIGFkZHMgc3Vw cG9ydCBmb3IgQ29yZUNoaXAtc3ogU1I5NzAwIGJhc2VkIFVTQiAxLjENCj4gICAgIDEwLzEwMCBF dGhlcm5ldCBhZGFwdGVycy4NCj4gIA0KPiArY29uZmlnIFVTQl9ORVRfU1I5ODAwDQo+ICsgdHJp c3RhdGUgIkNvcmVDaGlwLXN6IFNSOTgwMCBiYXNlZCBVU0IgMi4wIDEwLzEwMCBldGhlcm5ldCBk ZXZpY2VzIg0KPiArIGRlcGVuZHMgb24gVVNCX1VTQk5FVA0KPiArIHNlbGVjdCBDUkMzMg0KPiAr IGRlZmF1bHQgeQ0KV2h5IGlzIHRoaXMgc2VsZWN0ZWQgYnkgZGVmYXVsdD8gSSBjYW4gc2VlIHRo YXQgc29tZSBvZiB0aGUgb3RoZXIgVVNCDQpuZXR3b3JrIGRyaXZlcnMgYXJlIGFsc28gc2VsZWN0 ZWQgYnkgZGVmYXVsdCwgYnV0IG5vdCBhbGwgb2YgdGhlbS4gSXMNCnRoZXJlIHNvbWUgcnVsZSBv ZiB0aHVtYiBhcyB0byB3aGljaCBzaG91bGQgZGVmYXVsdCB0byB5IGFuZCB3aGljaA0Kc2hvdWxk bid0Pw0KVGhpZXJyeQ0KLS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NClZlcnNpb246IEdu dVBHIHYyLjAuMjIgKEdOVS9MaW51eCkNCmlRSWNCQUVCQWdBR0JRSlMrMGtkQUFvSkVOMGpyTmQv UHJPaFh2d1FBSklXNHZndjBOa3lRVm81alN2emVMWTQNCjlQRkNydGQ2TjFuK083UDk5eDM4SkND RDlsV3RmZGluMUVaZmorVWljQ2FudXAyV3pweUJXSGVCaGRTTjRvWkENCi8rQytUZ0VJdVgwK0Jl MTFJWGVVT0dNUDlhM2svMTJIWTNvSHV6N0JBMkpqY0s2UG5mTXhhRUM3aUdHSlNqZ3oNCnE0R29h NWtTcWp2TmdiUDhoNWJRUFROdE1uUmRzU3l0STdQTUpibDR0MWhvMFY3SDNwU285ekQ3cnhhUGht dEUNCnYvMThWUWF3R2NZODNIcjBCMFExOFhBbk5YYVFNTFpUdmRoVmZEVXhCNVZLVDRYaGNyaTBt NGFkYkF6TUk5a1INCks5Q0VDaGtEbjY4eTEzZHJKVklMS3FValcrNExNUUhBc1FWMDd5bDk4U3Fr N0xZT2VkTDltUU9uSUwwY3JqV2ENCk9BbUxId0x2MEVEMjVXMUh2M1VkZVNwQmRJa085Y0QwUENh N3ZIUW52N2xwVGxrYUR5WWVsS0xRMkQrR1hyQ3cNCjFMLzM0MWFrOVFFR2lDVTFUaU9IRGJsbnNO K090Q3QwUHQraGlqTEhGbDRUUUt3M1FJVW9aTGE0YlF1RFBNOE0NCmp1VFNWNjNIUmppRGxOR3Z0 akJlemxSOUdGdTV3M1NKdU5TTnNGa1o3QURKd2p6OU9uOUphRHdIL0FkN0FxbVoNCnlsRSt6emJJ cE9XanlOVG9NSDJkYXR0cGVWWmtJZkdrUzAyeTZQY0l4NTFFR013NUI4bDZxS0xCOVlwa0pwd1IN CjdyaE1ZanBMS0luLzZyUkdsd21aS1luV1lsN3AvRmRJMHlPblZidE1ZeDQwNml2VU5jK2tndm14 NWwxbVhoVDcNCmI4Z0tLWVlBMHBNRU1Yamdua0sxDQo9M3k3WA0KLS0tLS1FTkQgUEdQIFNJR05B VFVSRS0tLS0tDQo=