From: Florian Westphal <fw@strlen.de>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Patrick McHardy <kaber@trash.net>,
Cong Wang <cwang@twopensource.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vitaly Lavrov <lve@guap.ru>
Subject: Re: ip_set: protocol %u message -- useful?
Date: Thu, 13 Feb 2014 20:59:08 +0100 [thread overview]
Message-ID: <20140213195908.GK25153@breakpoint.cc> (raw)
In-Reply-To: <CAKb7UvjdPco0zrP9Ry4mPv40r-bnfNgKEfwcOvJb4JU-5XcTaw@mail.gmail.com>
Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> > Maybe printing "using protocol version X" will make it appear less like
> > a debugging message referring to packet contents or something similar.
>
> With pr_info it'll still appear in dmesg, and it'll still be "random
> non-sensical message appears over and over in dmesg" type of
> situation, to the vast majority of users. Do we need a print every
> time someone creates a new tcp connection too? I'm still not totally
> clear on the cause of this message getting printed, but I was seeing
> it a whole bunch in my configuration...
Yes, because it erronously got moved into the netns init function.
And thats what causes the spew. Moving it back into module init
function should be enough.
next prev parent reply other threads:[~2014-02-13 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:30 ip_set: protocol %u message -- useful? Ilia Mirkin
2014-02-13 10:30 ` Jozsef Kadlecsik
2014-02-13 18:32 ` Cong Wang
2014-02-13 18:42 ` Patrick McHardy
2014-02-13 18:58 ` Ilia Mirkin
2014-02-13 19:59 ` Florian Westphal [this message]
2014-02-13 20:55 ` Jozsef Kadlecsik
2014-02-13 19:02 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213195908.GK25153@breakpoint.cc \
--to=fw@strlen.de \
--cc=cwang@twopensource.com \
--cc=imirkin@alum.mit.edu \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=lve@guap.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.