From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>,
Tommi Rantala <tt.rantala@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
trinity@vger.kernel.org
Subject: Re: lockdep: strange %s#5 lock name
Date: Thu, 13 Feb 2014 22:32:53 +0100 [thread overview]
Message-ID: <20140213213253.GF27965@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140213212645.GG17608@htj.dyndns.org>
On Thu, Feb 13, 2014 at 04:26:45PM -0500, Tejun Heo wrote:
> > It seems to me that when the second time alloc_workqueue() is called
> > from the same code path, it would have two locks with the same key, but
> > not the same &wq->name, which doesn't meet lockdep's assumption.
>
> Dang... I reverted the previous patch for now. Peter, does this
> approach sound good to you?
Whatever works I suppose; like Li said; a little ugly but not sure we
can do better.
next prev parent reply other threads:[~2014-02-13 21:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 19:19 lockdep: strange %s#5 lock name Tommi Rantala
2014-02-10 19:28 ` Peter Zijlstra
2014-02-10 21:52 ` Tejun Heo
2014-02-11 11:00 ` Peter Zijlstra
2014-02-11 15:27 ` Tejun Heo
2014-02-13 4:35 ` Li Zhong
2014-02-13 21:26 ` Tejun Heo
2014-02-13 21:32 ` Peter Zijlstra [this message]
2014-02-13 22:15 ` Tejun Heo
2014-02-14 2:52 ` [PATCH ] workqueue: add args to workqueue lockdep name Li Zhong
2014-02-14 14:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213213253.GF27965@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tj@kernel.org \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.