From: Dave Jones <davej@redhat.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Joe Perches <joe@perches.com>,
Stephen Hemminger <stephen@networkplumber.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: remove unnecessary return's
Date: Thu, 13 Feb 2014 17:00:21 -0500 [thread overview]
Message-ID: <20140213220021.GA1174@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402132252290.1967@localhost6.localdomain6>
On Thu, Feb 13, 2014 at 10:55:23PM +0100, Julia Lawall wrote:
> The patch below converts label: return; } to label: ; }. I have only
> scanned through the patches, not patched the code and looked at the
> results, so I am not sure that it is completely correct. On the other
> hand, I'm also not sure that label: ; } is better than label: return; },
> either. If people think it is, then I can cheack the results in more
> detail.
Why not delete the label, and just replace the goto with a return if
the label is at the end of the function ?
Dave
next prev parent reply other threads:[~2014-02-13 22:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 4:51 [PATCH net-next] net: remove unnecessary return's Stephen Hemminger
2014-02-13 6:32 ` Joe Perches
2014-02-13 16:02 ` Stephen Hemminger
2014-02-13 21:55 ` Julia Lawall
2014-02-13 22:00 ` Dave Jones [this message]
2014-02-13 22:06 ` Julia Lawall
2014-02-13 22:28 ` Julia Lawall
2014-02-13 23:14 ` David Miller
2014-02-14 9:58 ` Julia Lawall
2014-02-14 18:41 ` David Miller
2014-02-14 18:48 ` Dave Jones
2014-02-13 23:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213220021.GA1174@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.