Re: [PATCH v2] openntpd: Add recipe for building OpenNTPD

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Feb 14, 2014 at 10:27:13AM -0500, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Nelson, Sam
> > Sent: Wednesday, February 12, 2014 11:03 PM
> > To: Dmytriyenko, Denys
> > Cc: meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH v2] openntpd: Add recipe for building
> > OpenNTPD
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Wednesday, February 12, 2014 2:38 PM
> > > To: Nelson, Sam
> > > Cc: meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [PATCH v2] openntpd: Add recipe for building
> > > OpenNTPD
> > >
> > > On Wed, Feb 12, 2014 at 01:33:49PM -0500, Sam Nelson wrote:
> > > > - OpenNTPD is a open source implementation of Network time protocol
> > > >
> > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > >
> > > > ---
> > > > Changes from previous patch
> > > > * Moved to recipes-connectivity
> > > > * Removed redundant setting of STAGING_KERNEL_DIR
> > > > ---
> > > > ---
> > > >  .../openntpd/openntpd_3.9p1.bb                     |   26
> > ++++++++++++++++++++
> > > >  1 file changed, 26 insertions(+)
> > > >  create mode 100755 meta-arago-extras/recipes-
> > > connectivity/openntpd/openntpd_3.9p1.bb
> > > >
> > > > diff --git a/meta-arago-extras/recipes-
> > > connectivity/openntpd/openntpd_3.9p1.bb b/meta-arago-extras/recipes-
> > > connectivity/openntpd/openntpd_3.9p1.bb
> > > > new file mode 100755
> > > > index 0000000..ca090e4
> > > > --- /dev/null
> > > > +++ b/meta-arago-extras/recipes-
> > > connectivity/openntpd/openntpd_3.9p1.bb
> > > > @@ -0,0 +1,26 @@
> > > > +DESCRIPTION = "OpenNTPD is a FREE, easy to use implementation of
> > the \
> > > > +Network Time Protocol."
> > > > +HOMEPAGE = "http://www.openntpd.org/"
> > > > +SECTION = "console/network"
> > > > +LICENSE = "BSD ISC"
> > > > +LIC_FILES_CHKSUM =
> > > "file://LICENCE;md5=4b4f5158007cc97e6b0e2325bb99854a"
> > > > +
> > > > +DEPENDS += "virtual/kernel"
> > > > +PR = "r0"
> > > > +
> > > > +SRC_URI =
> > > "http://mirror.ece.vt.edu/pub/OpenBSD/OpenNTPD/${P}.tar.gz"
> > > > +
> > > > +S = "${WORKDIR}/openntpd-${PV}"
> > > > +EXTRA_OECONF = "--disable-strip"
> > > > +inherit autotools
> > > > +
> > > > +LDFLAGS += "-lrt"
> > > > +CFLAGS += "-DTI_ADD_SUPPORT_HW_TIMESTAMPING"
> > > > +CPPFLAGS = "-I${STAGING_KERNEL_DIR}/include"
> > > > +CPPFLAGS += "-I${STAGING_KERNEL_DIR}/arch/arm/include"
> > >
> > > Sam, I keep seeing you passing staged kernel location to user-space apps
> > and
> > > daemons and I'm growing suspicious that it's not really needed... Both
> > > openntpd and linuxptp should be buildable as is w/o needing to have
> > access
> > > to
> > > the staged kernel. Unless I'm missing something and they do use kernel
> > > headers
> > > directly (not libc provided) and you have those headers modified for your
> > > platform... Can you please elaborate here? Thanks.
> > >
> > [Sam]  I checked on openntp and looks like the kernel reference may be
> > unnecessary.  This recipe came from tci6614 and I will check on more details.
> > But linuxptp does depend on kernel headers.

> [Sam] I was wrong, the openntp looks like does depend on H/W timestamping 
> defines from the kernel header based on local expert here. So recipe should 
> be pushed as is.

Can you please be more specific - what defines and in which files?

The reason I'm asking is that you use both of those user-space networking 
daemons directly from upstream w/o modifications. So, even if they do include 
kernel header files and require some specific defines, they work with a well 
defined user-space API that should exist on any other regular Linux system. 
And that means the headers should come from linux-libc-headers, not directly 
from the kernel.


> > > > +EXTRA_OECONF += "CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> > > CFLAGS="${CFLAGS}" \
> > > > +                 --with-privsep-user=root --with-privsep-path=/${prefix}"
> > > > +
> > > > +SRC_URI[md5sum] = "afc34175f38d08867c1403d9008600b3"
> > > > +SRC_URI[sha256sum] =
> > >
> > "83dd7c1e8ec8b4567afe49af539271b5a73562fb7a3ca51df73eccba89ec8c49
> > > "
> > > > --
> > > > 1.7.9.5
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago