From: Dan Carpenter <dan.carpenter@oracle.com>
To: Levente Kurusa <levex@linux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
OSUOSL Drivers <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check
Date: Sat, 15 Feb 2014 01:00:41 +0300 [thread overview]
Message-ID: <20140214220041.GD26722@mwanda> (raw)
In-Reply-To: <1392414623-4369-1-git-send-email-levex@linux.com>
On Fri, Feb 14, 2014 at 10:50:23PM +0100, Levente Kurusa wrote:
> Since MSR_AP is 0x3, ANDing it with 0xFC will never be true.
> Add a NOT operation to 0xFC so that we will AND with the last
> three bits which will result in a possibility that the condition
> will succeed.
>
> Signed-off-by: Levente Kurusa <levex@linux.com>
> ---
> Hi,
>
> This might not be the real solution since it is also possible that
> the particular condition never really happens. I seek comments
> so that I can post the proper patch.
>
I can't test it either but I think your fix is correct.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-14 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 21:50 [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check Levente Kurusa
2014-02-14 22:00 ` Dan Carpenter [this message]
2014-02-15 7:53 ` Levente Kurusa
2014-02-15 10:36 ` Dan Carpenter
2014-02-15 10:56 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214220041.GD26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.