From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC PATCH v4 01/10] driver core: export driver_probe_device() Date: Fri, 14 Feb 2014 14:27:16 -0800 Message-ID: <20140214222716.GA11838@kroah.com> References: <1391880580-471-1-git-send-email-a.motakis@virtualopensystems.com> <1391880580-471-2-git-send-email-a.motakis@virtualopensystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1391880580-471-2-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Antonios Motakis Cc: B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org, "Rafael J. Wysocki" , agraf-l3A5Bk7waGM@public.gmane.org, R65777-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Guenter Roeck , Dmitry Kasatkin , B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Bjorn Helgaas , tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, Toshi Kani , a.rigo-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Joe Perches , Tejun Heo , christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Sat, Feb 08, 2014 at 06:29:31PM +0100, Antonios Motakis wrote: > From: Kim Phillips > > Needed by drivers, such as the vfio platform driver [1], seeking to > bypass bind_store()'s driver_match_device(), and bind to any device > via a private sysfs bind file. > > [1] https://lkml.org/lkml/2013/12/11/522 > > note: the EXPORT_SYMBOL is needed because vfio-platform can be built > as a module. No code outside of drivers/base/ should be calling this function, you are doing something wrong in your bus if you want to do this, please fix your bus code. sorry, I can't accept this at all. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbaBNWZ6 (ORCPT ); Fri, 14 Feb 2014 17:25:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45819 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbaBNWZ5 (ORCPT ); Fri, 14 Feb 2014 17:25:57 -0500 Date: Fri, 14 Feb 2014 14:27:16 -0800 From: Greg KH To: Antonios Motakis Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, tech@virtualopensystems.com, a.rigo@virtualopensystems.com, B08248@freescale.com, kim.phillips@linaro.org, jan.kiszka@siemens.com, kvm@vger.kernel.org, R65777@freescale.com, B07421@freescale.com, christoffer.dall@linaro.org, agraf@suse.de, B16395@freescale.com, will.deacon@arm.com, Tejun Heo , "Rafael J. Wysocki" , Guenter Roeck , Toshi Kani , Joe Perches , Dmitry Kasatkin , Michal Hocko , Bjorn Helgaas Subject: Re: [RFC PATCH v4 01/10] driver core: export driver_probe_device() Message-ID: <20140214222716.GA11838@kroah.com> References: <1391880580-471-1-git-send-email-a.motakis@virtualopensystems.com> <1391880580-471-2-git-send-email-a.motakis@virtualopensystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391880580-471-2-git-send-email-a.motakis@virtualopensystems.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 08, 2014 at 06:29:31PM +0100, Antonios Motakis wrote: > From: Kim Phillips > > Needed by drivers, such as the vfio platform driver [1], seeking to > bypass bind_store()'s driver_match_device(), and bind to any device > via a private sysfs bind file. > > [1] https://lkml.org/lkml/2013/12/11/522 > > note: the EXPORT_SYMBOL is needed because vfio-platform can be built > as a module. No code outside of drivers/base/ should be calling this function, you are doing something wrong in your bus if you want to do this, please fix your bus code. sorry, I can't accept this at all. greg k-h