From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WEhMo-0006Op-7T for mharc-grub-devel@gnu.org; Sat, 15 Feb 2014 10:41:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEhMi-0006MD-5b for grub-devel@gnu.org; Sat, 15 Feb 2014 10:41:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEhMb-0004S6-Cr for grub-devel@gnu.org; Sat, 15 Feb 2014 10:41:16 -0500 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:38939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEhMb-0004Rn-4z for grub-devel@gnu.org; Sat, 15 Feb 2014 10:41:09 -0500 Received: by mail-la0-f48.google.com with SMTP id mc6so9988375lab.21 for ; Sat, 15 Feb 2014 07:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Xh7abfz94MTl1QDdwzXY3kofdpuf5WBmKvf+TOgqWyw=; b=B2ksiEWHLZcG0FSwYnOMv13f4zOkRicTfruAZSWN/iuh5lBUzVt3MouHN+EJ/pRGnz j5eUDlao8FqiDsLkUOas66N9E+rJvt6qAhkgWNEj2kIrx3ufsJuCo1hdaiGhSlWhiHrc smwvhl4SDJ0UKp9IVz2oZMIzCxGocwcnefzvul8FDXYXbz0K6QYvFk2Z4tzGqAlde+lO XOay5aBcTo7KP84nIoItWBVcfTEDMpdAmHqk3xAIv6o6P0aXKlEwT22TXbjn4+hvVJLB 3ETgxUQ4iaebU8lR0ExDhLylA+lwpYap1Mqt33h1nGhbf8/mUqqv+p8g5hQHRk+VNG6u kteA== X-Received: by 10.112.132.102 with SMTP id ot6mr9520171lbb.27.1392478866843; Sat, 15 Feb 2014 07:41:06 -0800 (PST) Received: from opensuse.site (ppp91-76-154-95.pppoe.mtu-net.ru. [91.76.154.95]) by mx.google.com with ESMTPSA id gb8sm10354686lbc.13.2014.02.15.07.41.05 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 15 Feb 2014 07:41:06 -0800 (PST) Date: Sat, 15 Feb 2014 19:41:05 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: Proposal for fixing bootinfoscript when grub v2.00 sits on the MBR Message-ID: <20140215194105.5016dd09@opensuse.site> In-Reply-To: <52FF7E23.8030208@gmx.fr> References: <52FF7E23.8030208@gmx.fr> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::230 Cc: arbiel.perlacremaz@gmx.fr, "yannubuntu@gmail.com" , meierfra@ubuntuforums.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Feb 2014 15:41:20 -0000 В Sat, 15 Feb 2014 15:48:03 +0100 "Arbiel (gmx)" пишет: > Hi > > Apparently, you are in charge of maintaining bootinfoscript. > > It turns out that the script does not correctly discriminate grub2's > versions 1.99 and 2.00. > Botinfoscript is unrelated to grub development. You can find version with my fixes submitted upstream but never applied at https://github.com/arvidjaar/bootinfoscript It should correctly parse current master as well as offer some sugar on top (like parsing embedded prefix or config). I may add listing of modules as well. > To understand why, I've studied the release available for download at > http://sourceforge.net/p/bootinfoscript/code/ci/master/tree/ > and used by "boot-repair", a boot repairing tool written by YannUbuntu. > > I found out that the mistake comes from the fact that bootinfoscript > looks in core.img for a 6-byte value of "d1 e9 df fe ff ff" and, when > found, looks at the following two bytes for either "66 90" or "8d b6" to > deduce that grub2's version is 2.00. For any other value, it deduces the > version to be 1.99, whereas the latter should be deduced only from a "00 > 00" value, if the comments inside the script's code are reliable. > > I've installed grub2 v2.00 from a Ubuntu distribution and it happens > that the two bytes following the "d1 e9 df fe ff ff" token hold a third > value, namely "8d 76". I obviously do not know whether this third value > is a "good" value to be considered as a grub v2.00 token or if the > search for "d1 e9 df fe ff ff" should be continued until it reaches a > "good" "00 00", "66 90" or "8d b6" value into the two following bytes. > > Could you please investigate this issue, and possibly update > bootinfoscript ? > > Thank's in advance. > > Arbiel > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel