Re: [PATCH 2/2] cml1.bbclass: Add fragmentconfig task to cml1

["João Henrique Ferreira de Freitas" <joaohf@gmail.com>]

Hi Darren,

> $ bitbake linux-yocto -c diffconfig
> 
> I like the latter because it is consistent in naming, <action>config,
> with menuconfig.
> 

Ok.

> >+    try:
> >+        md5newconfig = bb.utils.md5_file(configorig)
> >+        md5config = bb.utils.md5_file(config)
> >+        isdiff = md5newconfig != md5config
> >+    except OSError:
> 
> We should be doing something to indicate failure here.

Ok. 

> 
> >+
> >+        statement = 'diff -Nurp ' + configorig + ' ' + config + '|
> >sed -n "s/^\+//p" >' + fragment
> >+        subprocess.call(statement, shell=True)
> >+
> >+        shutil.copy(configorig, config)
> 
> We should be printing something to make it easy for the user to find
> the fragment.

I've suppose that the bb.note did it. But  the messages doesn't appear
on console. Only in the log.do_diffconfig log file.

What is the trick here? Should I use bb.warn() or logger.info() ?

Thanks.

-- 
João Henrique Ferreira de Freitas - joaohf_at_gmail.com
Campinas-SP-Brasil