From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nftables: fix nf_trace always-on with XT_TRACE=n
Date: Sun, 16 Feb 2014 12:06:27 +0100 [thread overview]
Message-ID: <20140216110627.GE28751@breakpoint.cc> (raw)
In-Reply-To: <20140216104311.GA3563@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > OTOH I think that trace support is a very important thing to have and I
> > doubt that compiling it out would save a lot of size.
> >
> > But sure, if you think it makes sense I can add CONFIG_NF_TRACE and
> > make nf_tables tracing conditional.
>
> This is just a cosmetic comment, but I can live with that long #if
> line. Leave it up to you to decide.
I see. I that case please consider applying the present patch.
I think adding extra kconfig symbol just for the sake of avoiding
two longer IS_ENABLED() statements is plain overkill :-)
next prev parent reply other threads:[~2014-02-16 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 22:48 [PATCH] netfilter: nftables: fix nf_trace always-on with XT_TRACE=n Florian Westphal
2014-02-16 10:20 ` Pablo Neira Ayuso
2014-02-16 10:28 ` Florian Westphal
2014-02-16 10:43 ` Pablo Neira Ayuso
2014-02-16 10:45 ` Patrick McHardy
2014-02-16 11:06 ` Florian Westphal [this message]
2014-02-17 10:40 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140216110627.GE28751@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.