From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: hskinnemoen@gmail.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using.
Date: Mon, 17 Feb 2014 10:50:48 +0100 [thread overview]
Message-ID: <20140217095048.GA20665@samfundet.no> (raw)
In-Reply-To: <52ECEA2A.8070307@gmail.com>
Around Sat 01 Feb 2014 20:35:54 +0800 or thereabout, Chen Gang wrote:
> For avr32 cross compiler, do not define '__linux__' internally, so it
> will cause issue with allmodconfig.
>
> The related error:
>
> CC [M] fs/coda/psdev.o
> In file included from include/linux/coda.h:64,
> from fs/coda/psdev.c:45:
> include/uapi/linux/coda.h:221: error: expected specifier-qualifier-list before 'u_quad_t'
>
> The related toolchain version (which only download, not re-compile):
>
> [root@gchen linux-next]# /upstream/toolchain/download/avr32-gnu-toolchain-linux_x86/bin/avr32-gcc -v
> Using built-in specs.
> Target: avr32
> Configured with: /data2/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/src/gcc/configure --target=avr32 --host=i686-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-languages=c,c++ --disable-nls --disable-libssp --disable-libstdcxx-pch --with-dwarf2 --enable-version-specific-runtime-libs --disable-shared --enable-doc --with-mpfr-lib=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/lib --with-mpfr-include=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86/include --with-gmp=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --with-mpc=/home/toolsbuild/jenkins-knuth/workspace/avr32-gnu-toolchain/avr32-gnu-toolchain-linux_x86 --enable-__cxa_atexit --disable-shared --with-newlib --with-pkgversion=AVR_32_bit_GNU_Toolchain_3.4.2_435 --with-bugurl=http://www
> .atmel.com/avr
> Thread model: single
> gcc version 4.4.7 (AVR_32_bit_GNU_Toolchain_3.4.2_435)
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
I will merge this into the avr32 tree in the for-linus branch. AFAICT this is
also suitable for stable, so I'll add the appropriate CC.
> ---
> arch/avr32/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/Makefile b/arch/avr32/Makefile
> index 22fb665..dba48a5 100644
> --- a/arch/avr32/Makefile
> +++ b/arch/avr32/Makefile
> @@ -11,7 +11,7 @@ all: uImage vmlinux.elf
>
> KBUILD_DEFCONFIG := atstk1002_defconfig
>
> -KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic
> +KBUILD_CFLAGS += -pipe -fno-builtin -mno-pic -D__linux__
> KBUILD_AFLAGS += -mrelax -mno-pic
> KBUILD_CFLAGS_MODULE += -mno-relax
> LDFLAGS_vmlinux += --relax
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2014-02-17 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 12:35 [PATCH] arch: avr32: Makefile: add '-D__linux__' flag for gcc-4.4.7 using Chen Gang
2014-02-01 12:56 ` Richard Weinberger
2014-02-01 13:46 ` Chen Gang
2014-02-16 11:40 ` Chen Gang
2014-02-17 9:50 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217095048.GA20665@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=gang.chen.5i5j@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.