From: Patrick McHardy <kaber@trash.net>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] src: proto: fixed a rreply symbol
Date: Mon, 17 Feb 2014 10:46:43 +0000 [thread overview]
Message-ID: <20140217104643.GA31632@macbook.localnet> (raw)
In-Reply-To: <1392633683-5485-1-git-send-email-anarey@gmail.com>
On Mon, Feb 17, 2014 at 11:41:23AM +0100, Ana Rey wrote:
> There is a bug with rreply symbol. The rreply and reply symbol were the same.
>
> There is a reproduction of this bug here:
> $ sudo nft add rule arp art-t filter arp operation reply
> $ sudo nft list table arp art-t
> table arp art-t {
> chain filter {
> type filter hook input priority 0;
> arp operation 512
> }
> }
>
> $ sudo nft add rule arp art-t filter arp operation rreply
> $ sudo nft list table arp art-t
> table arp art-t {
> chain filter {
> type filter hook input priority 0;
> arp operation 512 <=====
> arp operation 512 <=====
> }
> }
Applied, thanks.
Please remember to sign off your patches next time.
>
> src/proto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/proto.c b/src/proto.c
> index cc073af..3e62f92 100644
> --- a/src/proto.c
> +++ b/src/proto.c
> @@ -661,7 +661,7 @@ static const struct symbol_table arpop_tbl = {
> SYMBOL("request", ARPOP_REQUEST),
> SYMBOL("reply", ARPOP_REPLY),
> SYMBOL("rrequest", ARPOP_RREQUEST),
> - SYMBOL("rreply", ARPOP_REPLY),
> + SYMBOL("rreply", ARPOP_RREPLY),
> SYMBOL("inrequest", ARPOP_InREQUEST),
> SYMBOL("inreply", ARPOP_InREPLY),
> SYMBOL("nak", ARPOP_NAK),
> --
> 1.8.5.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-02-17 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 10:41 [PATCH] src: proto: fixed a rreply symbol Ana Rey
2014-02-17 10:46 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217104643.GA31632@macbook.localnet \
--to=kaber@trash.net \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.