From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver Date: Mon, 17 Feb 2014 12:03:26 +0000 Message-ID: <20140217120326.GC20218@lee--X1> References: <1392199238-14500-1-git-send-email-rogerable@realtek.com> <1392199238-14500-2-git-send-email-rogerable@realtek.com> <20140214094427.GA7380@lee--X1> <5301A786.8040607@realtek.com> <20140217082222.GA17875@lee--X1> <5301D369.5010100@realtek.com> <20140217100211.GE17875@lee--X1> <5301E376.8010000@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5301E376.8010000@realtek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Roger Cc: Ulf Hansson , Maxim Levitsky , Alex Dubov , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn, Andrew Morton , Dan Carpenter , Samuel Ortiz List-Id: linux-mmc@vger.kernel.org PiA+Pj4+Pj5Gcm9tOiBSb2dlciBUc2VuZyA8cm9nZXJhYmxlQHJlYWx0ZWsuY29tPgo+ID4+Pj4+ Pgo+ID4+Pj4+PlJlYWx0ZWsgVVNCIGNhcmQgcmVhZGVyIHByb3ZpZGVzIGEgY2hhbm5lbCB0byB0 cmFuc2ZlciBjb21tYW5kIG9yIGRhdGEgdG8gZmxhc2gKPiA+Pj4+Pj5tZW1vcnkgY2FyZHMuIFRo aXMgZHJpdmVyIGV4cG9ydHMgaG9zdCBpbnN0YW5jZXMgZm9yIG1tYyBhbmQgbWVtc3RpY2sgc3Vi c3lzdGVtcwo+ID4+Pj4+PmFuZCBoYW5kbGVzIGJhc2ljIHdvcmtzLgo+ID4+Pj4+Pgo+ID4+Pj4+ PlNpZ25lZC1vZmYtYnk6IFJvZ2VyIFRzZW5nIDxyb2dlcmFibGVAcmVhbHRlay5jb20+Cj4gPj4+ Pj4+LS0tCj4gPj4+Pj4+ICBkcml2ZXJzL21mZC9LY29uZmlnICAgICAgICAgIHwgIDEwICsKPiA+ Pj4+Pj4gIGRyaXZlcnMvbWZkL01ha2VmaWxlICAgICAgICAgfCAgIDEgKwo+ID4+Pj4+PiAgZHJp dmVycy9tZmQvcnRzeF91c2IuYyAgICAgICB8IDc2MCArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gPj4+Pj4+ICBpbmNsdWRlL2xpbnV4L21mZC9ydHN4X3VzYi5o IHwgNjI4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4+Pj4+ICA0IGZp bGVzIGNoYW5nZWQsIDEzOTkgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+PiAgY3JlYXRlIG1vZGUgMTAw NjQ0IGRyaXZlcnMvbWZkL3J0c3hfdXNiLmMKPiA+Pj4+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBp bmNsdWRlL2xpbnV4L21mZC9ydHN4X3VzYi5oCj4gPj4+Pj4KPiA+Pj4+PkFwcGxpZWQgYWdhaW4s IHRoYW5rcy4KPiA+Pj4+Pgo+ID4+Pj5Xb3VsZCB5b3UgYWxzbyBhcHBseSBwYXRjaCAyLzMgYW5k IDMvMyB0aGF0IHRvIG1ha2UgdGhlIGRldmljZSBmdWxseQo+ID4+Pj5vcGVyYXRpb25hbCBmb3Ig dXNlcnM/IE9yIHNob3VsZCB0aGV5IGJlIGFwcGxpZWQgYnkgbWFpbnRhaW5lcnMgb2YKPiA+Pj4+ bW1jL21lbXN0aWNrIHN1YnN5c3RlbXM/Cj4gPj4+Pgo+ID4+Pj5DaHJpcywgd291bGQgeW91IGdp dmUgc29tZSBjb21tZW50Pwo+ID4+Pgo+ID4+PkkgY2FuIGFwcGx5IHRoZW0sIGJ1dCBJIG5lZWQg dGhlIG90aGVyIE1haW50YWluZXIgQWNrcy4KPiA+Pj4KPiA+Pj5JZiB0aGV5IGFyZSBidWlsZCBv cnRob2dvbmFsIGkuZS4gdGhlcmUgYXJlIG5vIGJ1aWxkIGRlcGVuZGVuY2llcwo+ID4+PmJldHdl ZW4gdGhlbSwgaXQncyBwcm9iYWJseSBiZXR0ZXIgdGhhdCB0aGV5IGdvIGludG8gdGhlaXIgYXNz b2NpYXRlZAo+ID4+PnRyZWVzIHNlcGFyYXRlbHkuCj4gPj4+Cj4gPj5JIHRoaW5rIGl0IHdvdWxk IGJlIGJldHRlciB0byBhcHBseSB0aGVtIHRvZ2V0aGVyIHNpbmNlIHRoZSBsYXRlcgo+ID4+cGF0 Y2hlcyByZWFsbHkgZGVwZW5kIG9uIHRoZSAxc3Qgb25lLHNvIG5vdyB3ZSBhcmUgd2FpdGluZyBm b3IgQWNrcwo+ID4+ZnJvbSBtbWMvbWVtc3RpY2sgc3Vic3lzdGVtcy4KPiA+Cj4gPldoZW4geW91 IHNheSAiZGVwZW5kIG9uIiwgZG8geW91IG1lYW4gYXMgYSBidWlsZCBkZXBlbmVuY3ksIG9yIHdv bid0Cj4gPnJ1biB3aXRob3V0IHRoZSBmaXJzdCBwYXRjaCBhcHBsaWVkPwo+IAo+IFRoZSBsYXRl ciAyIHBhdGNoZXMgYWN0dWFsbHkgaW52b2tlIHN5bWJvbHMgZGVmaW5lZCBpbiB0aGUgZmlyc3QK PiBwYXRjaCBhbmQgd29uJ3QgY29tcGlsZSBpZiBpdCBpcyBub3QgYXBwbGllZCBmaXJzdC4gVGhl IEtjb25maWcKPiBjaGFuZ2VzIGZvciB0aGUgbGF0ZXIgb25lc3MgYWxzbyBzcGVjaWZpZWQgdGhp cyBieSAiZGVwZW5kcyBvbiIuCj4gCj4gSSdtIG5vdCBzdXJlIGlmIHRoaXMgbWVhbnMgImJ1aWxk IGRlcGVuZGVuY3kiLiBTb3JyeSBmb3IgbXkgdW5jbGVhciB3b3Jkcy4KClllcywgdGhhdCBzb3Vu ZHMgbGlrZSBhIGJ1aWxkIGRlcGVuZGVuY3kgaS5lLiB3aWxsIG5vdCBidWlsZCB3aXRob3V0CmVy cm9ycyBvciB3YXJuaW5ncyB3aXRob3V0IHRoZSBwcmV2aW91cyBwYXRjaCBhcHBsaWVkLgoKPiA+ PkJ1dCB0aGVyZSBpcyBubyBvbmUgc3BlY2lmaWVkIGZvciAibWVtc3RpY2svaG9zdC8iIGluIE1B SU5UQUlORVJTLgo+ID4+Q291bGQgYW55b25lIGVsc2UgQWNrIHRoaXM/CgpBbmRyZXcgKENDJ2Vk KSBoYXMgYmVlbiBBY2tpbmcgdGhlc2UgdGh1cyBmYXIuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBT VE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBz b3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdp dHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDov L2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVy ZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbaBQMDf (ORCPT ); Mon, 17 Feb 2014 07:03:35 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:65301 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838AbaBQMDd (ORCPT ); Mon, 17 Feb 2014 07:03:33 -0500 Date: Mon, 17 Feb 2014 12:03:26 +0000 From: Lee Jones To: Roger Cc: Samuel Ortiz , Chris Ball , Greg Kroah-Hartman , Maxim Levitsky , Alex Dubov , Dan Carpenter , Ulf Hansson , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn, micky_ching@realsil.com.cn, Andrew Morton Subject: Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver Message-ID: <20140217120326.GC20218@lee--X1> References: <1392199238-14500-1-git-send-email-rogerable@realtek.com> <1392199238-14500-2-git-send-email-rogerable@realtek.com> <20140214094427.GA7380@lee--X1> <5301A786.8040607@realtek.com> <20140217082222.GA17875@lee--X1> <5301D369.5010100@realtek.com> <20140217100211.GE17875@lee--X1> <5301E376.8010000@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5301E376.8010000@realtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>>>>>From: Roger Tseng > >>>>>> > >>>>>>Realtek USB card reader provides a channel to transfer command or data to flash > >>>>>>memory cards. This driver exports host instances for mmc and memstick subsystems > >>>>>>and handles basic works. > >>>>>> > >>>>>>Signed-off-by: Roger Tseng > >>>>>>--- > >>>>>> drivers/mfd/Kconfig | 10 + > >>>>>> drivers/mfd/Makefile | 1 + > >>>>>> drivers/mfd/rtsx_usb.c | 760 +++++++++++++++++++++++++++++++++++++++++++ > >>>>>> include/linux/mfd/rtsx_usb.h | 628 +++++++++++++++++++++++++++++++++++ > >>>>>> 4 files changed, 1399 insertions(+) > >>>>>> create mode 100644 drivers/mfd/rtsx_usb.c > >>>>>> create mode 100644 include/linux/mfd/rtsx_usb.h > >>>>> > >>>>>Applied again, thanks. > >>>>> > >>>>Would you also apply patch 2/3 and 3/3 that to make the device fully > >>>>operational for users? Or should they be applied by maintainers of > >>>>mmc/memstick subsystems? > >>>> > >>>>Chris, would you give some comment? > >>> > >>>I can apply them, but I need the other Maintainer Acks. > >>> > >>>If they are build orthogonal i.e. there are no build dependencies > >>>between them, it's probably better that they go into their associated > >>>trees separately. > >>> > >>I think it would be better to apply them together since the later > >>patches really depend on the 1st one,so now we are waiting for Acks > >>from mmc/memstick subsystems. > > > >When you say "depend on", do you mean as a build depenency, or won't > >run without the first patch applied? > > The later 2 patches actually invoke symbols defined in the first > patch and won't compile if it is not applied first. The Kconfig > changes for the later oness also specified this by "depends on". > > I'm not sure if this means "build dependency". Sorry for my unclear words. Yes, that sounds like a build dependency i.e. will not build without errors or warnings without the previous patch applied. > >>But there is no one specified for "memstick/host/" in MAINTAINERS. > >>Could anyone else Ack this? Andrew (CC'ed) has been Acking these thus far. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog