From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFOKX-000073-RR for qemu-devel@nongnu.org; Mon, 17 Feb 2014 08:33:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFOKR-0005DG-L2 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 08:33:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFOKR-0005D6-D5 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 08:33:47 -0500 Date: Mon, 17 Feb 2014 21:32:51 +0800 From: Fam Zheng Message-ID: <20140217133251.GG1428@T430.redhat.com> References: <1390972061-26560-1-git-send-email-famz@redhat.com> <1390972061-26560-11-git-send-email-famz@redhat.com> <20140213134832.GF4547@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140213134832.GF4547@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v13 10/14] qmp: Add command 'blockdev-backup' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Thu, 02/13 14:48, Beno=EEt Canet wrote: > The Wednesday 29 Jan 2014 =E0 13:07:37 (+0800), Fam Zheng wrote : > > Similar to drive-backup, but this command uses a device id as target > > instead of creating/opening an image file. > >=20 > > Also add blocker on target bs, since the target is also a named devic= e > > now. > >=20 > > Add check and report error for bs =3D=3D target which became possible= but is > > an illegal case with introduction of blockdev-backup. > >=20 > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 26 ++++++++++++++++++++++++++ > > blockdev.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++= + > > qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++++++++++= +++ > > qmp-commands.hx | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 166 insertions(+) > >=20 > > diff --git a/block/backup.c b/block/backup.c > > index 15a2e55..ea46340 100644 > > --- a/block/backup.c > > +++ b/block/backup.c > > @@ -344,6 +344,7 @@ static void coroutine_fn backup_run(void *opaque) > > hbitmap_free(job->bitmap); > > =20 > > bdrv_iostatus_disable(target); > > + bdrv_op_unblock_all(target, job->common.blocker); > > bdrv_unref(target); > > =20 > > block_job_completed(&job->common, ret); > > @@ -362,6 +363,11 @@ void backup_start(BlockDriverState *bs, BlockDri= verState *target, > > assert(target); > > assert(cb); > > =20 > > + if (bs =3D=3D target) { > > + error_setg(errp, "Source and target cannot be the same"); > > + return; > > + } > > + > > if ((on_source_error =3D=3D BLOCKDEV_ON_ERROR_STOP || > > on_source_error =3D=3D BLOCKDEV_ON_ERROR_ENOSPC) && > > !bdrv_iostatus_is_enabled(bs)) { > > @@ -369,6 +375,24 @@ void backup_start(BlockDriverState *bs, BlockDri= verState *target, > > return; > > } > > =20 > > + if (!bdrv_is_inserted(bs)) { > > + error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, bs->device_name); > > + return; > > + } > > + > > + if (!bdrv_is_inserted(target)) { > > + error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, target->device_na= me); > > + return; > > + } > > + > > + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_BACKUP_SOURCE, errp)) { > > + return; > > + } > > + > > + if (bdrv_op_is_blocked(target, BLOCK_OP_TYPE_BACKUP_TARGET, errp= )) { > > + return; > > + } > > + > > len =3D bdrv_getlength(bs); > > if (len < 0) { > > error_setg_errno(errp, -len, "unable to get length for '%s'"= , > > @@ -382,6 +406,8 @@ void backup_start(BlockDriverState *bs, BlockDriv= erState *target, > > return; > > } > > =20 > > + bdrv_op_block_all(target, job->common.blocker); > > + > > job->on_source_error =3D on_source_error; > > job->on_target_error =3D on_target_error; > > job->target =3D target; > > diff --git a/blockdev.c b/blockdev.c > > index ffaa6a9..b346cc1 100644 > > --- a/blockdev.c > > +++ b/blockdev.c > > @@ -1940,6 +1940,8 @@ void qmp_drive_backup(const char *device, const= char *target, > > return; > > } > > =20 > > + /* Although backup_run has this check too, we need to use bs->dr= v below, so > > + * do an early check redundantly. */ > > if (!bdrv_is_inserted(bs)) { > > error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device); > > return; > > @@ -1956,6 +1958,7 @@ void qmp_drive_backup(const char *device, const= char *target, > > } > > } > > =20 > > + /* Early check to avoid creating target */ > > if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_BACKUP_SOURCE, errp)) { > > return; > > } > > @@ -2019,6 +2022,50 @@ BlockDeviceInfoList *qmp_query_named_block_nod= es(Error **errp) > > return bdrv_named_nodes_list(); > > } > > =20 > > +void qmp_blockdev_backup(const char *device, const char *target, > > + enum MirrorSyncMode sync, > > + bool has_speed, int64_t speed, > > + bool has_on_source_error, > > + BlockdevOnError on_source_error, > > + bool has_on_target_error, > > + BlockdevOnError on_target_error, > > + Error **errp) > > +{ > > + BlockDriverState *bs; > > + BlockDriverState *target_bs; > > + Error *local_err =3D NULL; > > + > > + if (!has_speed) { > > + speed =3D 0; > > + } > > + if (!has_on_source_error) { > > + on_source_error =3D BLOCKDEV_ON_ERROR_REPORT; > > + } > > + if (!has_on_target_error) { > > + on_target_error =3D BLOCKDEV_ON_ERROR_REPORT; > > + } > > + > > + bs =3D bdrv_find(device); > This and the qmp prototype should be upgraded to the new device and nod= e-name > alternative and make use of bdrv_lookup_bs(). >=20 Can we do it later in a separate patch? Fam