All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] staging/bcm: two information leaks in ioctl
Date: Mon, 17 Feb 2014 20:13:16 +0000	[thread overview]
Message-ID: <20140217201316.GJ26722@mwanda> (raw)
In-Reply-To: <20140217195606.GA32630@elgon.mountain>

On Mon, Feb 17, 2014 at 02:59:19PM -0500, Dave Jones wrote:
> On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote:
>  > There are a couple paths where we don't check how much data we copy back
>  > to the user.
> 
> I'm curious, is this something smatch is only picking up now that
> I chopped up that mega function into lots of little functions ?

Yes.  Smatch wasn't able to parse it before the breakup.  Too huge.

regards,
dan carpenter


  parent reply	other threads:[~2014-02-17 20:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 19:56 [patch 1/2] staging/bcm: two information leaks in ioctl Dan Carpenter
2014-02-17 19:59 ` Dave Jones
2014-02-17 20:13 ` Dan Carpenter [this message]
2014-02-17 20:23 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217201316.GJ26722@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.