From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Date: Mon, 17 Feb 2014 20:23:34 +0000 Subject: Re: [patch 1/2] staging/bcm: two information leaks in ioctl Message-Id: <20140217202334.GA27162@redhat.com> List-Id: References: <20140217195606.GA32630@elgon.mountain> In-Reply-To: <20140217195606.GA32630@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Mon, Feb 17, 2014 at 11:13:16PM +0300, Dan Carpenter wrote: > On Mon, Feb 17, 2014 at 02:59:19PM -0500, Dave Jones wrote: > > On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote: > > > There are a couple paths where we don't check how much data we copy back > > > to the user. > > > > I'm curious, is this something smatch is only picking up now that > > I chopped up that mega function into lots of little functions ? > > Yes. Smatch wasn't able to parse it before the breakup. Too huge. Excellent. That gives me incentive to do that sort of crap work more often. Dave