From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sylvain BERTRAND <sylware@legeek.net>
Subject: [radeonsi] si_populate_sq_ramping_values
Date: Mon, 17 Feb 2014 23:08:46 +0100
Message-ID: <20140217220846.GA285@freedom>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtpauth-vit.online.net (smtpauth-vit.online.net
	[88.190.253.76])
	by gabe.freedesktop.org (Postfix) with ESMTP id 28143FA8F7
	for <dri-devel@lists.freedesktop.org>;
	Mon, 17 Feb 2014 14:08:49 -0800 (PST)
Received: from [88.188.175.165] (helo=localhost)
	by smtpauth-vit.online.net with esmtpsa
	(TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
	(envelope-from <sylware@legeek.net>) id 1WFWMp-00045W-2z
	for dri-devel@lists.freedesktop.org; Mon, 17 Feb 2014 23:08:47 +0100
Content-Disposition: inline
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi,

In si_dpm.c, si_populate_sq_ramping_values function,

It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.

----

Moreover should it be:
if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

instead of:
if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

----

The previous does disable "sq ramping" for good on all SI,
expected?

regards,

-- 
Sylvain