From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Ian Nartowicz <claws@nartowicz.co.uk>,
Tao Ma <tm@tao.ma>, Andreas Dilger <adilger.kernel@dilger.ca>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [RFC][PATCH] ext4: handle fast symlink properly with inline_data
Date: Mon, 17 Feb 2014 20:52:31 -0500 [thread overview]
Message-ID: <20140218015231.GF26580@thunk.org> (raw)
In-Reply-To: <1392275237-6998-1-git-send-email-wenqing.lz@taobao.com>
On Thu, Feb 13, 2014 at 03:07:17PM +0800, Zheng Liu wrote:
>
> I am not sure whether or not we need to enable inline_data for a fast
> symlink inode. Obviously, it brings a benefit that after enabling
> inline_data feature for a fast symlink we can get more space to store
> the path. But it seems that the original patch doesn't want to do this
> Another solution for fixing this bug is to disable inline_data for a
> fast symlink. Any comment?
Well, if we are using inline data, and we have a symlink which is
longer than 60 bytes, but less than extra space available for an
inline data, it seems like a good thing to support.
The downside is that it is a bit more complication to add the kernel's
code in both the kernel as well as e2fsprogs, but it doesn't seem that
bad.
So I don't have any objections to adding this functionality. What do
other folks think?
- Ted
next prev parent reply other threads:[~2014-02-18 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 7:07 [RFC][PATCH] ext4: handle fast symlink properly with inline_data Zheng Liu
2014-02-13 17:05 ` Ian Nartowicz
2014-02-18 1:52 ` Theodore Ts'o [this message]
2014-02-18 19:07 ` Andreas Dilger
2014-05-30 23:26 ` Darrick J. Wong
2014-06-02 6:42 ` Zheng Liu
2014-06-02 11:06 ` Ian Nartowicz
2014-06-02 11:54 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218015231.GF26580@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=claws@nartowicz.co.uk \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.