From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate Date: Tue, 18 Feb 2014 20:46:44 +1100 Message-ID: <20140218094644.GD28666@dastard> References: <1391319874-3203-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Namjae Jeon , tytso@mit.edu, Namjae Jeon , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, bpm@sgi.com, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, Ashish Sangwan , linux-fsdevel@vger.kernel.org, jack@suse.cz, linux-ext4@vger.kernel.org, mtk.manpages@gmail.com To: =?utf-8?B?THVrw6HFoQ==?= Czerner Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-ext4.vger.kernel.org T24gVHVlLCBGZWIgMTgsIDIwMTQgYXQgMTA6MDU6NDlBTSArMDEwMCwgTHVrw6HFoSBDemVybmVy IHdyb3RlOgo+IE9uIFdlZCwgMTIgRmViIDIwMTQsIE5hbWphZSBKZW9uIHdyb3RlOgo+IAo+ID4g RGF0ZTogV2VkLCAxMiBGZWIgMjAxNCAxMToyODozNSArMDkwMAo+ID4gRnJvbTogTmFtamFlIEpl b24gPGxpbmtpbmplb25AZ21haWwuY29tPgo+ID4gVG86IEx1a8OhxaEgQ3plcm5lciA8bGN6ZXJu ZXJAcmVkaGF0LmNvbT4KPiA+IENjOiB2aXJvQHplbml2LmxpbnV4Lm9yZy51aywgZGF2aWRAZnJv bW9yYml0LmNvbSwgYnBtQHNnaS5jb20sIHR5dHNvQG1pdC5lZHUsCj4gPiAgICAgYWRpbGdlci5r ZXJuZWxAZGlsZ2VyLmNhLCBqYWNrQHN1c2UuY3osIG10ay5tYW5wYWdlc0BnbWFpbC5jb20sCj4g PiAgICAgbGludXgtZnNkZXZlbEB2Z2VyLmtlcm5lbC5vcmcsIHhmc0Bvc3Muc2dpLmNvbSwKPiA+ ICAgICBsaW51eC1leHQ0QHZnZXIua2VybmVsLm9yZywgbGludXgta2VybmVsQHZnZXIua2VybmVs Lm9yZywKPiA+ICAgICBOYW1qYWUgSmVvbiA8bmFtamFlLmplb25Ac2Ftc3VuZy5jb20+LAo+ID4g ICAgIEFzaGlzaCBTYW5nd2FuIDxhLnNhbmd3YW5Ac2Ftc3VuZy5jb20+Cj4gPiBTdWJqZWN0OiBS ZTogW1BBVENIIFJFU0VORCAzLzEwXSBleHQ0OiBBZGQgc3VwcG9ydCBGQUxMT0NfRkxfQ09MTEFQ U0VfUkFOR0UKPiA+ICAgICBmb3IgZmFsbG9jYXRlCj4gPiAKPiA+IDIwMTQtMDItMTEgMjA6NTkg R01UKzA5OjAwLCBMdWvDocWhIEN6ZXJuZXIgPGxjemVybmVyQHJlZGhhdC5jb20+Ogo+ID4gPiBP biBTdW4sIDIgRmViIDIwMTQsIE5hbWphZSBKZW9uIHdyb3RlOgo+ID4gPgo+ID4gPj4gRGF0ZTog U3VuLCAgMiBGZWIgMjAxNCAxNDo0NDozNCArMDkwMAo+ID4gPj4gRnJvbTogTmFtamFlIEplb24g PGxpbmtpbmplb25AZ21haWwuY29tPgo+ID4gPj4gVG86IHZpcm9AemVuaXYubGludXgub3JnLnVr LCBkYXZpZEBmcm9tb3JiaXQuY29tLCBicG1Ac2dpLmNvbSwKPiA+ID4+IHR5dHNvQG1pdC5lZHUs Cj4gPiA+PiAgICAgYWRpbGdlci5rZXJuZWxAZGlsZ2VyLmNhLCBqYWNrQHN1c2UuY3osIG10ay5t YW5wYWdlc0BnbWFpbC5jb20KPiA+ID4+IENjOiBsaW51eC1mc2RldmVsQHZnZXIua2VybmVsLm9y ZywgeGZzQG9zcy5zZ2kuY29tLAo+ID4gPj4gICAgIGxpbnV4LWV4dDRAdmdlci5rZXJuZWwub3Jn LCBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnLAo+ID4gPj4gICAgIE5hbWphZSBKZW9uIDxs aW5raW5qZW9uQGdtYWlsLmNvbT4sIE5hbWphZSBKZW9uCj4gPiA+PiA8bmFtamFlLmplb25Ac2Ft c3VuZy5jb20+LAo+ID4gPj4gICAgIEFzaGlzaCBTYW5nd2FuIDxhLnNhbmd3YW5Ac2Ftc3VuZy5j b20+Cj4gPiA+PiBTdWJqZWN0OiBbUEFUQ0ggUkVTRU5EIDMvMTBdIGV4dDQ6IEFkZCBzdXBwb3J0 IEZBTExPQ19GTF9DT0xMQVBTRV9SQU5HRQo+ID4gPj4gZm9yCj4gPiA+PiAgICAgZmFsbG9jYXRl Cj4gPiA+Pgo+ID4gPj4gRnJvbTogTmFtamFlIEplb24gPG5hbWphZS5qZW9uQHNhbXN1bmcuY29t Pgo+ID4gPj4KPiA+ID4+IEFkZCBzdXBwb3J0IEZBTExPQ19GTF9DT0xMQVBTRV9SQU5HRSBmb3Ig ZmFsbG9jYXRlCj4gPiBIaSBMdWthcy4KPiA+ID4KPiA+ID4gRGVzY3JpcHRpb24gaXMgbWlzc2lu ZyBoZXJlLCBwbGVhc2UgcHJvdmlkZSBGQUxMT0NfRkxfQ09MTEFQU0VfUkFOR0UKPiA+ID4gZGVz Y3JpcHRpb24gc28gcGVvcGxlIGtub3cgd2hhdCBpdCdzIHN1cHBvc2VkIHRvIGJlIGRvaW5nLgo+ ID4gPgo+ID4gPiBtb3JlIGNvbW1lbnRzIGJlbGxvdy4KPiA+IE9rYXksIEkgd2lsbCB1ZHBhdGUu Cj4gPiA+Cj4gPiA+IFRoYW5rcyEKPiA+ID4gLUx1a2FzCj4gCj4gSGksCj4gCj4geW91IG1heSBo YXZlIG5vdGljZWQgbXkgcGF0Y2hlcyBmb3IgbmV3IEZBTExPQ19GTF9aRVJPX1JBTkdFCj4gZmFs bG9jYXRlIGZsYWcuIFRoaXMgY2hhbmdlcyB0aGluZ3MgYXJvdW5kIHRoZSBzYW1lIGFyZWEgYXMg eW91cgo+IHBhdGNoZXMgZG9lcyBzbyB3ZSBzaG91bGQgcHJvYmFibHkgZmlndXJlIG91dCB3aGlj aCBhcmUgZ29pbmcgdG8KPiBsYW5kIGluIGZpcnN0IGFuZCB0aGVuIHJlYmFzZSB0aGUgb3RoZXIg b24gdG9wIG9mIHRoYXQuCj4gCj4gT25lIGNvbmNlcm4gSSBoYXZlIGlzIHRoYXQgSSBoYXZlIG5v dCBzZWVuIGFueSB0ZXN0cyBwcm92aWRlZCB0bwo+IHZlcmlmeSB0aGUgZmVhdHVyZS4gQnV0IEkg anVzdCBtYXkgaGF2ZSBtaXNzZWQgaXQuIERvIHlvdSBoYXZlIGFueQo+IHhmc3Rlc3RzIHRlc3Qg b3IgYXQgbGVhc3QgZnN4IGFuZCBmc3N0cmVzcyBwYXRjaGVzIHRvIHByb3ZpZGUKPiBzdXBwb3J0 IGZvciB0ZXN0aW5nIEZBTExPQ19GTF9DT0xMQVBTRV9SQU5HRSA/IFBhdGNoZXMgZm9yCj4gdXRp bF9saW51eCBtaWdodCBhbHNvIGJlIGhhbmR5LgoKVGhlcmUgd2VyZSA1IHhmc3Rlc3RzIHBhdGNo ZXMgcG9zdGVkIHRoYXQgdXNlZCB0aGUKX3Rlc3RfZ2VuZXJpY19wdW5jaCBpbmZyYXN0cnVjdHVy ZSB0byB0ZXN0IHRoaXMgZnVuY3Rpb25hbGl0eS4KU2VlIHRoZSBkZWNlbWJlciAwOCBpbmRleCBo ZXJlLCBzZWFyY2ggZm9yICJzaGFyZWQvMDBbMS01XSI6CgpodHRwOi8vb3NzLnNnaS5jb20vYXJj aGl2ZXMveGZzLzIwMTMtMTIvaW5kZXguaHRtbAoKVGhleSBuZWVkIGEgbGl0dGxlIHJld29yaywg YnV0IG90aGVyd2lzZSB0aGUgdGVzdCBjb2RlIGlzIHRoZXJlLgpIYXZpbmcgdGhlIGZlYXR1cmUg YWRkZWQgdG8gZnN4IGFuZCBmc3N0cmVzcyB3b3VsZCBwcm9iYWJseSBiZSBhCmdvb2QgaWRlYSwg dGhvdWdoLgoKQ2hlZXJzLAoKRGF2ZS4KLS0gCkRhdmUgQ2hpbm5lcgpkYXZpZEBmcm9tb3JiaXQu Y29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwp4ZnMg bWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNnaS5jb20vbWFpbG1hbi9s aXN0aW5mby94ZnMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbaBRJqw (ORCPT ); Tue, 18 Feb 2014 04:46:52 -0500 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:42307 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754472AbaBRJqt (ORCPT ); Tue, 18 Feb 2014 04:46:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmwOALoqA1N5LJYe/2dsb2JhbABZgwY4g1mlHwORV4VUgRQXdIIlAQEFIw8BIyMQCAECEQMBAgECAgUhAgIPBQ0YAxMOE4dxAxAOjQqbf5lxDYgPFxaBE4s+GYIBB4JvNYEUBJZAgWuKUIIPhUWBb4FSKA Date: Tue, 18 Feb 2014 20:46:44 +1100 From: Dave Chinner To: =?utf-8?B?THVrw6HFoQ==?= Czerner Cc: Namjae Jeon , viro@zeniv.linux.org.uk, bpm@sgi.com, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ashish Sangwan Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate Message-ID: <20140218094644.GD28666@dastard> References: <1391319874-3203-1-git-send-email-linkinjeon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2014 at 10:05:49AM +0100, Lukáš Czerner wrote: > On Wed, 12 Feb 2014, Namjae Jeon wrote: > > > Date: Wed, 12 Feb 2014 11:28:35 +0900 > > From: Namjae Jeon > > To: Lukáš Czerner > > Cc: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com, tytso@mit.edu, > > adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com, > > linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, > > linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > > Namjae Jeon , > > Ashish Sangwan > > Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE > > for fallocate > > > > 2014-02-11 20:59 GMT+09:00, Lukáš Czerner : > > > On Sun, 2 Feb 2014, Namjae Jeon wrote: > > > > > >> Date: Sun, 2 Feb 2014 14:44:34 +0900 > > >> From: Namjae Jeon > > >> To: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com, > > >> tytso@mit.edu, > > >> adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com > > >> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, > > >> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > > >> Namjae Jeon , Namjae Jeon > > >> , > > >> Ashish Sangwan > > >> Subject: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE > > >> for > > >> fallocate > > >> > > >> From: Namjae Jeon > > >> > > >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate > > Hi Lukas. > > > > > > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE > > > description so people know what it's supposed to be doing. > > > > > > more comments bellow. > > Okay, I will udpate. > > > > > > Thanks! > > > -Lukas > > Hi, > > you may have noticed my patches for new FALLOC_FL_ZERO_RANGE > fallocate flag. This changes things around the same area as your > patches does so we should probably figure out which are going to > land in first and then rebase the other on top of that. > > One concern I have is that I have not seen any tests provided to > verify the feature. But I just may have missed it. Do you have any > xfstests test or at least fsx and fsstress patches to provide > support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for > util_linux might also be handy. There were 5 xfstests patches posted that used the _test_generic_punch infrastructure to test this functionality. See the december 08 index here, search for "shared/00[1-5]": http://oss.sgi.com/archives/xfs/2013-12/index.html They need a little rework, but otherwise the test code is there. Having the feature added to fsx and fsstress would probably be a good idea, though. Cheers, Dave. -- Dave Chinner david@fromorbit.com