[Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra.

[Eric Le Bihan <eric.le.bihan.dev@free.fr>]

Hi!

On Mon, Feb 17, 2014 at 03:37:45PM +0100, Thomas Petazzoni wrote:

> > With the <foo>_CONFIGURE_CMDS method, we go through all the dummy steps, and
> > this is very verbose:
> >
> >   >>> udev undefined Extracting
> >   >>> udev undefined Patching
> >   >>> udev undefined Configuring
> >   echo "No Udev implementation selected. Configuration error."
> >   No Udev implementation selected. Configuration error.
> >   exit 1
> >   make: *** [/home/eric/build/elebihan/demo-systemd/arm/build/udev-undefined/.stamp_configured] Erreur 1
> >
> > With the pure Makefile version, the error message is clearer:
> >
> >   package/udev/udev.mk:11: *** No Udev implementation selected. Configuration error. Stop.
>
> Yes, I believe this is better. And the message is given at the very
> beginning of the build, not when udev starts to be built, which is also
> nicer.
I've made some further testing and unfortunately, the pure "make" solution
does not work. The test on <foo>_DEPENDENCIES is performed when the Makefile
is evaluated, whether <foo> virtual package is selected or not.

If virtual package <foo> is not selected, <foo>_DEPENDENCIES will be empty, so
the test is true and the error message is displayed. That's not what we want.

Using <foo>_CONFIGURE_CMDS, the test will only be performed if the package is
selected.

So, I'll stick with the current method (I'll had some '@' to silence the shell
commands though).

Best regards,
ELB