From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 18 Feb 2014 12:24:10 +0000 Subject: re: regmap: Separate regmap dev initialization Message-Id: <20140218122410.GA9825@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Hello Michal Simek, The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization" from Feb 10, 2014, leads to the following static checker warning: drivers/base/regmap/regmap.c:765 regmap_init() warn: add curly braces? drivers/base/regmap/regmap.c 759 ret = regcache_init(map, config); 760 if (ret != 0) 761 goto err_range; 762 763 if (dev) 764 ret = regmap_attach_dev(dev, map, config); 765 if (ret != 0) 766 goto err_regcache; Please add curly braces or adjust the indenting to not confuse the static checkers. 767 768 return map; regards, dan carpenter