From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: missing dependency on libxlu_disk_l.h
Date: Tue, 18 Feb 2014 14:56:41 +0100
Message-ID: <20140218135641.GB2804@aepfle.de>
References: <20140215221737.GA28254@aepfle.de>
	<1392718729.11080.13.camel@kazak.uk.xensource.com>
	<21251.17769.656791.139815@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <21251.17769.656791.139815@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 18, Ian Jackson wrote:

> Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> > It might be a good idea to either also patch the generated files or to
> > have the patch remove them, to avoid any possible confusion due to skew.
> This ought to be taken care of by the build system, provided you don't
> actually git commit only the change to .l and not the change to .[ch].
> In the final patch.

In my case the patch changes only the .l file. I expect that all
dependencies are written into the Makefile.

> Olaf, can you test whether this diff makes the problem go away for you ?

Ian, xen.rpm is rebuilt often, but the failure happend exactly once.
I will see if I can force it to fail without the change below.

Olaf

> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
>  $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>  
>  AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> -	_libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> +	libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
>  AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
>  AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
>  LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \