From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 7/7] Makefile: export PATH
Date: Tue, 18 Feb 2014 16:37:56 +0100 [thread overview]
Message-ID: <20140218163756.0e495167@skate> (raw)
In-Reply-To: <5302FE90.9070402@mind.be>
Dear Arnout Vandecappelle,
On Tue, 18 Feb 2014 07:32:48 +0100, Arnout Vandecappelle wrote:
> On 16/02/14 14:58, Samuel Martin wrote:
> > This can be useful for:
> > - package using custom build system that are not aware that the host
> > tree is in $(O)/host/;
> > - post-{build,image} scripts, in case some host-tools were specifically
> > built to be used by these scripts.
>
> This makes all the previous patches redundant, since the PATH=...
> invocations should be removed instead of renamed.
Agreed. Samuel, you should make a choice:
* Either you use BR_PATH, and we continue to pass PATH=$(BR_PATH)
whenever the PATH is needed.
* Or you simply directly export PATH with the right value, and remove
all occurrences where we manually pass PATH=<something>.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-18 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 13:58 [Buildroot] [PATCH v4 0/7] PATH cleanup Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 1/7] bustle: use TARGET_MAKE_ENV instead of setting PATH in the make environment Samuel Martin
2014-02-18 15:35 ` Thomas Petazzoni
2014-02-16 13:58 ` [Buildroot] [PATCH v4 2/7] Makefile: introduce BR_PATH Samuel Martin
2014-02-18 6:25 ` Arnout Vandecappelle
2014-02-16 13:58 ` [Buildroot] [PATCH v4 3/7] Makefile: add $(HOST_DIR)/sbin to BR_PATH Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 4/7] *.mk: replace (TARGET|HOST)_PATH by BR_PATH Samuel Martin
2014-02-18 6:28 ` Arnout Vandecappelle
2014-02-16 13:58 ` [Buildroot] [PATCH v4 5/7] infra: remove unused {TARGET, HOST}_PATH definition Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 6/7] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-02-16 13:58 ` [Buildroot] [PATCH v4 7/7] Makefile: export PATH Samuel Martin
2014-02-18 6:32 ` Arnout Vandecappelle
2014-02-18 15:37 ` Thomas Petazzoni [this message]
2014-02-18 15:55 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218163756.0e495167@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.