From: Steffen Klassert <steffen.klassert@secunet.com>
To: Xianpeng Zhao <673321875@qq.com>
Cc: netdev <netdev@vger.kernel.org>, alan <alan@lxorguk.ukuu.org.uk>
Subject: Re: Fw:[Bug 70471] xfrm policy node will double unlink.
Date: Wed, 19 Feb 2014 12:43:26 +0100 [thread overview]
Message-ID: <20140219114326.GE32371@secunet.com> (raw)
In-Reply-To: <tencent_4CE06FA903D8DCB54F951A30@qq.com>
On Wed, Feb 19, 2014 at 10:07:14AM +0800, Xianpeng Zhao wrote:
> Hi Steffen,
>
> This problem is happened when running stress test; Very little chance can get this case.
>
> As you say, add a long time sleep in function xfrm_policy_bysel_ctx between __xfrm_policy_unlink and
> xfrm_policy_kill, will reproduce this issue manually.
>
> About my patch, I am not sure it is OK, because after it patched, the issue had reproduced once, but after some days test recently, have not reproduced again.
>
> But I can make sure when __xfrm_policy_unlink find the node had been removed, return NULL instead of delete again will fix this problem.
>
> What's your suggestions?
>
Please test the patch I've sent with the last mail.
Thanks!
next prev parent reply other threads:[~2014-02-19 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 2:55 Fw:[Bug 70471] xfrm policy node will double unlink Xianpeng Zhao
2014-02-18 8:37 ` Steffen Klassert
2014-02-19 2:07 ` Xianpeng Zhao
2014-02-19 11:43 ` Steffen Klassert [this message]
2014-02-20 2:01 ` Xianpeng Zhao
2014-02-21 7:35 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219114326.GE32371@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=673321875@qq.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.