From: Tejun Heo <tj@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Oliver Schinagl <oliver@schinagl.nl>,
Richard Zhu <Hong-Xing.Zhu@freescale.com>,
Roger Quadros <rogerq@ti.com>, Lee Jones <lee.jones@linaro.org>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v6 05/18] ahci-platform: Add support for an optional regulator for sata-target power
Date: Wed, 19 Feb 2014 09:53:56 -0500 [thread overview]
Message-ID: <20140219145356.GD10134@htj.dyndns.org> (raw)
In-Reply-To: <1392811320-3132-6-git-send-email-hdegoede@redhat.com>
On Wed, Feb 19, 2014 at 01:01:47PM +0100, Hans de Goede wrote:
> @@ -268,6 +281,9 @@ pdata_exit:
> pdata->exit(dev);
> disable_unprepare_clk:
> ahci_disable_clks(hpriv);
> +disable_regulator:
> + if (hpriv->target_pwr)
> + regulator_disable(hpriv->target_pwr);
The same thing with clks, I'd much prefer to see ahci_platform doing
devres wrapping so that its consumers wouldn't have to worry about
tearing stuff down.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 05/18] ahci-platform: Add support for an optional regulator for sata-target power
Date: Wed, 19 Feb 2014 09:53:56 -0500 [thread overview]
Message-ID: <20140219145356.GD10134@htj.dyndns.org> (raw)
In-Reply-To: <1392811320-3132-6-git-send-email-hdegoede@redhat.com>
On Wed, Feb 19, 2014 at 01:01:47PM +0100, Hans de Goede wrote:
> @@ -268,6 +281,9 @@ pdata_exit:
> pdata->exit(dev);
> disable_unprepare_clk:
> ahci_disable_clks(hpriv);
> +disable_regulator:
> + if (hpriv->target_pwr)
> + regulator_disable(hpriv->target_pwr);
The same thing with clks, I'd much prefer to see ahci_platform doing
devres wrapping so that its consumers wouldn't have to worry about
tearing stuff down.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-02-19 14:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 12:01 [PATCH v6 00/18] ahci: library-ise ahci_platform, add sunxi driver and cleanup imx driver Hans de Goede
2014-02-19 12:01 ` Hans de Goede
[not found] ` <1392811320-3132-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-19 12:01 ` [PATCH v6 01/18] libahci: Allow drivers to override start_engine Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 14:42 ` Tejun Heo
2014-02-19 14:42 ` Tejun Heo
2014-02-19 12:01 ` [PATCH v6 02/18] libahci: Move ahci_host_priv declaration to include/linux/ahci.h Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 03/18] ahci-platform: Pass ahci_host_priv ptr to ahci_platform_data init method Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 04/18] ahci-platform: Add support for devices with more then 1 clock Hans de Goede
2014-02-19 12:01 ` Hans de Goede
[not found] ` <1392811320-3132-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-19 14:52 ` Tejun Heo
2014-02-19 14:52 ` Tejun Heo
2014-03-20 12:28 ` Ben Dooks
2014-03-20 12:28 ` Ben Dooks
2014-02-19 12:01 ` [PATCH v6 05/18] ahci-platform: Add support for an optional regulator for sata-target power Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 14:53 ` Tejun Heo [this message]
2014-02-19 14:53 ` Tejun Heo
2014-02-19 12:01 ` [PATCH v6 06/18] ahci-platform: Add enable_ / disable_resources helper functions Hans de Goede
2014-02-19 12:01 ` Hans de Goede
[not found] ` <1392811320-3132-7-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-19 14:55 ` Tejun Heo
2014-02-19 14:55 ` Tejun Heo
2014-02-19 12:01 ` [PATCH v6 07/18] ahci-platform: "Library-ise" ahci_probe functionality Hans de Goede
2014-02-19 12:01 ` Hans de Goede
[not found] ` <1392811320-3132-8-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-19 14:58 ` Tejun Heo
2014-02-19 14:58 ` Tejun Heo
2014-02-19 12:01 ` [PATCH v6 08/18] ahci-platform: "Library-ise" suspend / resume functionality Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 09/18] ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 10/18] ahci-imx: Port to library-ised ahci_platform Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 11/18] ata: ahci_platform: Add DT compatible for Synopsis DWC AHCI controller Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 12/18] ata: ahci_platform: Update DT compatible list Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 13/18] ata: ahci_platform: Manage SATA PHY Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 14/18] ata: ahci_platform: Add 'struct device' argument to ahci_platform_put_resources() Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 15/18] ata: ahci_platform: runtime resume the device before use Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 16/18] ARM: sun4i: dt: Remove grouping + simple-bus compatible for regulators Hans de Goede
2014-02-19 12:01 ` Hans de Goede
2014-02-19 12:01 ` [PATCH v6 17/18] ARM: sun4i: dt: Add ahci / sata support Hans de Goede
2014-02-19 12:01 ` Hans de Goede
[not found] ` <1392811320-3132-18-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-21 18:15 ` Maxime Ripard
2014-02-21 18:15 ` Maxime Ripard
2014-02-22 10:09 ` Hans de Goede
2014-02-22 10:09 ` Hans de Goede
[not found] ` <53087755.3090608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-22 17:15 ` Maxime Ripard
2014-02-22 17:15 ` Maxime Ripard
2014-02-22 19:10 ` Hans de Goede
2014-02-22 19:10 ` Hans de Goede
[not found] ` <5308F63E.3070300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-03-03 9:33 ` Maxime Ripard
2014-03-03 9:33 ` Maxime Ripard
2014-03-03 10:07 ` Hans de Goede
2014-03-03 10:07 ` Hans de Goede
2014-02-19 12:02 ` [PATCH v6 18/18] ARM: sun7i: " Hans de Goede
2014-02-19 12:02 ` Hans de Goede
2014-02-19 15:02 ` [PATCH v6 00/18] ahci: library-ise ahci_platform, add sunxi driver and cleanup imx driver Tejun Heo
2014-02-19 15:02 ` Tejun Heo
[not found] ` <20140219150249.GG10134-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-02-19 15:26 ` Hans de Goede
2014-02-19 15:26 ` Hans de Goede
[not found] ` <5304CD33.1080704-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-19 16:25 ` Tejun Heo
2014-02-19 16:25 ` Tejun Heo
[not found] ` <20140219162511.GJ10134-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-02-19 17:18 ` Hans de Goede
2014-02-19 17:18 ` Hans de Goede
2014-02-19 17:42 ` Tejun Heo
2014-02-19 17:42 ` Tejun Heo
2014-02-19 17:20 ` Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219145356.GD10134@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Hong-Xing.Zhu@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=oliver@schinagl.nl \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.