From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild,tegra124: add dummy obj- for Kbuild
Date: Wed, 19 Feb 2014 15:40:47 -0500 [thread overview]
Message-ID: <20140219204047.GF19081@bill-the-cat> (raw)
In-Reply-To: <5304DD7E.7070104@wwwdotorg.org>
On Wed, Feb 19, 2014 at 09:36:14AM -0700, Stephen Warren wrote:
> On 02/19/2014 07:46 AM, Albert ARIBAUD wrote:
> > Hi Masahiro,
> >
> > On Wed, 19 Feb 2014 22:26:43 +0900, Masahiro Yamada
> > <yamada.m@jp.panasonic.com> wrote:
> >
> >> In Kbuild, every makefile must have non-empty obj- or obj-y.
> >> Otherwise, built-in.o will not be created and the link stage
> >> will fail.
> ...
> >> diff --git a/arch/arm/cpu/armv7/tegra124/Makefile b/arch/arm/cpu/armv7/tegra124/Makefile
> ...
> >> +# necessary to create built-in.o
> >> +obj- := __dummy__.o
>
> obj- or obj-y?
>
> Adding something to obj-, which presumably isn't used at all, seems very
> odd.
Why do we even need arch/arm/cpu/armv7/tegra124/Makefile ? I assume we
need the config.mk because we can't stick CONFIG_ARCH_DEVICE_TREE into
the config header?
>
> > Is there really no other way than to specify an unexisting __dummy__.o
> > in order to build a useless built-in.o?
>
> I haven't looked at Kbuild at all, but in the build systems I've
> written, for each sub-directory makefile that was included, the
> makefiles would include a "pre-makefile" first and a "post-makefile"
> after. The "post-makefile" could easily do something like:
>
> ifeq ($(obj-y),)
> obg-y := __dummy__.o
> endif
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/50a2ffd6/attachment.pgp>
next prev parent reply other threads:[~2014-02-19 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 13:26 [U-Boot] [PATCH] kbuild,tegra124: add dummy obj- for Kbuild Masahiro Yamada
2014-02-19 14:46 ` Albert ARIBAUD
2014-02-19 16:36 ` Stephen Warren
2014-02-19 20:40 ` Tom Rini [this message]
2014-02-19 20:44 ` Stephen Warren
2014-02-20 8:35 ` Masahiro Yamada
2014-02-20 8:24 ` Masahiro Yamada
2014-02-20 16:15 ` Stephen Warren
2014-02-21 11:45 ` Masahiro Yamada
2014-02-21 16:33 ` Stephen Warren
2014-02-20 8:23 ` Masahiro Yamada
2014-02-20 9:06 ` Albert ARIBAUD
2014-02-19 20:51 ` Tom Rini
2014-02-20 8:22 ` Masahiro Yamada
2014-02-20 13:25 ` Tom Rini
2014-02-19 21:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219204047.GF19081@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.