From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC libdrm 2/6] libdrm: Add NVIDIA Tegra support Date: Wed, 19 Feb 2014 22:33:46 +0100 Message-ID: <20140219213345.GB31663@ulmo.nvidia.com> References: <1392825893-7380-1-git-send-email-thierry.reding@gmail.com> <1392825893-7380-3-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2038525878==" Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id C19FBFAFA0 for ; Wed, 19 Feb 2014 13:33:48 -0800 (PST) Received: by mail-bk0-f49.google.com with SMTP id v15so383746bkz.36 for ; Wed, 19 Feb 2014 13:33:48 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Erik Faye-Lund Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2038525878== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 19, 2014 at 09:03:51PM +0100, Erik Faye-Lund wrote: > On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding > wrote: > > +#ifndef __DRM_TEGRA_PRIVATE_H__ > > +#define __DRM_TEGRA_PRIVATE_H__ 1 > > + > > +#include > > +#include > > + > > +#include > > + > > +#include "tegra.h" > > + > > +#if defined(HAVE_VISIBILITY) > > +# define drm_private __attribute__((visibility("hidden"))) > > +# define drm_public __attribute__((visibility("default"))) > > +#else > > +# define drm_private > > +# define drm_public > > +#endif > > + >=20 > Perhaps you could put this where it's visible to other drivers as > well, like xf86drm.h? I'd prefer to keep this here for now. We can move it to a more central location when another module starts using it. Thierry --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTBSM5AAoJEN0jrNd/PrOhvhUP/Rz8fVugdaxlg3Lw9HNLfXUb MBE92Jmqtx2nvlnItjDjMazGMFDd0yYwSb0QfwuP5uYkDrBaLHlPkGdQ4ujooT0p 14JwSySjwmmt/oMW3c43pczBIHwF15FWqSA5OWMhh6IrmYCQmmWlb5evPW1jPtrI YdkEA2cqaaJg15nhGdjdAwWDJ4xscRQ1SPl7cu/UXMAJVm/gx0KzTPO5KmgDo5RL f7ilfgKBe8crAE++dZbui/r+msrlgV/XZsrlWIoaagmZNP2sY6RkfNqKrIcVMYnN Frvq5+2T5WT4u9Y8c5QWfgoCo0mIXjTXfC1zxkIwSfw2coYpeC4a3dAVfCMjEKE5 AF/1krR6yX5zUTOZz+0MeU40Zu2/b0zXeUSleK+Eazb8uEETN9TXmND+jNfItYaz 4hVHgzbR3tjyNXGMjoqOQzRWeEuU9RJakxNqgaik33LgNUqam5OHyOARxTkGpvnW NBwDyu5RNeX1Im9E8gFlY5f+NBMwrgaVko3z70db4lOBRYOL2NjEw8GEH8cLilGs /bjnWhQkh8GXDOEvDa2G0feczMCFbK3htJfi0aFJ8qnfONC9QNJ+R9TWLAVhgLX1 SvXflmJdZpA+DnZHjYjq1msePmArrUWycyLcuNgcxBqZ+6SRWstARmDFZ8IA30oj Mu/bLDdbAL+WQ+82YNQ5 =Oumr -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE-- --===============2038525878== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2038525878==--