From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
David Rientjes <rientjes@google.com>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH] Set bounds on what /proc/self/make-it-fail accepts.
Date: Wed, 19 Feb 2014 16:55:05 -0500 [thread overview]
Message-ID: <20140219215505.GA28876@redhat.com> (raw)
In-Reply-To: <20140219134025.fcd70941e1ec98723a1bd230@linux-foundation.org>
On Wed, Feb 19, 2014 at 01:40:25PM -0800, Andrew Morton wrote:
> Switching `make_it_fail' to unsigned makes the test simpler but it does
> rather muck up the typing in there. task_struct.make_it_fail is still
> an int, we should now use simple_strtoul rather than simple_strtol,
> proc_fault_inject_read()'s snprintf() should now use %u, etc. None of
> which actually matters, but still...
I toyed with the idea of changing task_struct.make_it_fail to unsigned too,
but only realized I missed that after I'd sent out the diff.
> Rather than address all that I'm inclined to leave `make_it_fail' as an
> int, turning your patch into a one-liner?
That works for me too.
Dave
next prev parent reply other threads:[~2014-02-19 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:06 [PATCH] Set bounds on what /proc/self/make-it-fail accepts Dave Jones
2014-02-18 22:32 ` David Rientjes
2014-02-18 23:27 ` Dave Jones
2014-02-19 13:48 ` Akinobu Mita
2014-02-19 21:37 ` David Rientjes
2014-02-19 21:40 ` Andrew Morton
2014-02-19 21:55 ` Dave Jones [this message]
2014-02-19 22:00 ` Andrew Morton
2014-02-19 22:07 ` David Rientjes
2014-02-19 22:31 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219215505.GA28876@redhat.com \
--to=davej@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.