From: Jiri Olsa <jolsa@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: Tejun Heo <tj@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()
Date: Thu, 20 Feb 2014 15:53:07 +0100 [thread overview]
Message-ID: <20140220145306.GC12948@krava.brq.redhat.com> (raw)
In-Reply-To: <5306150C.4020202@intel.com>
On Thu, Feb 20, 2014 at 10:45:32PM +0800, Lan Tianyu wrote:
> On 02/20/2014 10:31 PM, Jiri Olsa wrote:
> >On Thu, Feb 20, 2014 at 09:28:26PM +0800, Lan Tianyu wrote:
> >>On 02/19/2014 06:49 AM, Tejun Heo wrote:
> >>>Hello,
> >>>
> >>>On Mon, Feb 17, 2014 at 06:19:00PM +0100, Oleg Nesterov wrote:
> >>>>acpi_processor_set_throttling() plays with set_cpus_allowed_ptr(current),
> >>>>this is obviously wrong, and the worker is bound.
> >>>
> >>>Umm... yeah, anything running on workqueues shouldn't be diddling with
> >>>cpu affinity. The function even has /* FIXME: use work_on_cpu() */ in
> >>>it. I suppose it's about time to actually implement that?
> >>>
> >>>Thanks.
> >>>
> >>
> >>Hi Jiri:
> >> Could you try this patch which reworks ACPI processor throttling
> >>with work_on_cpu()?
> >
> >hum, I've got difficulties to apply it..
> >
> >[jolsa@krava2 linux-perf]$ git am /tmp/wq/
> >Applying: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()
> >fatal: corrupt patch at line 8
> >Patch failed at 0001 WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()
> >
> >jirka
> >
> Sorry. Please try the attachment again.
np, this one got applied cleanly ;-)
I started the workload.. it took several hours to hit
it before, I'll let you know
jirka
next prev parent reply other threads:[~2014-02-20 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140213124059.GA2908@krava.brq.redhat.com>
2014-02-17 17:19 ` WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70() Oleg Nesterov
2014-02-18 22:49 ` Tejun Heo
2014-02-20 13:28 ` Lan Tianyu
2014-02-20 14:31 ` Jiri Olsa
2014-02-20 14:45 ` Lan Tianyu
2014-02-20 14:53 ` Jiri Olsa [this message]
2014-02-20 15:13 ` Oleg Nesterov
2014-02-20 15:17 ` Oleg Nesterov
2014-02-21 2:34 ` Lan Tianyu
2014-02-21 5:35 ` [PATCH] ACPI/Processor: Rework processor throttling with work_on_cpu() Lan Tianyu
2014-02-21 10:06 ` Jiri Olsa
2014-02-21 17:07 ` Jiri Olsa
2014-02-24 9:27 ` Lan Tianyu
2014-02-24 9:27 ` Lan Tianyu
2014-02-26 1:23 ` Rafael J. Wysocki
2014-02-26 1:08 ` Lan Tianyu
2014-02-26 1:08 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220145306.GC12948@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tianyu.lan@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.