From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: fix sibling pointer tests in verify_dir2_path()
Date: Thu, 20 Feb 2014 07:41:22 -0800 [thread overview]
Message-ID: <20140220154122.GC26146@infradead.org> (raw)
In-Reply-To: <53051DB5.4080403@redhat.com>
On Wed, Feb 19, 2014 at 03:10:13PM -0600, Eric Sandeen wrote:
> RH QE reported that if we create a 1G filesystem with default
> options, mount it, and create inodes until full, then run
> repair, repair reports corruption in verify_dir2_path() with:
>
> > bad back pointer in block 8390324 for directory inode 131
Can you please wire this up for xfstests?
>
> The commit 88b32f0 xfs: add CRCs to dir2/da node blocks
> had a small error which regressed this; although we switch
> to the "newnode," to check sibling pointers, we re-populate
> the node hdr with the old "node" data. This causes the
> backpointer test to be testing the wrong node's values.
>
> Fixing this bug fixes the testcase.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-20 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 21:10 [PATCH] xfs_repair: fix sibling pointer tests in verify_dir2_path() Eric Sandeen
2014-02-20 15:41 ` Christoph Hellwig [this message]
2014-02-20 19:12 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220154122.GC26146@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.