All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] rename HAS_IOPORT to HAS_IOPORT_MAP
Date: Thu, 20 Feb 2014 16:24:19 +0100	[thread overview]
Message-ID: <201402201624.19922.arnd@arndb.de> (raw)
In-Reply-To: <1392854190-29596-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Thursday 20 February 2014, Uwe Kleine-König wrote:
> If the renamed symbol is defined lib/iomap.c implements ioport_map and
> ioport_unmap and currently (nearly) all platforms define the port
> accessor functions outb/inb and friend unconditionally. So
> HAS_IOPORT_MAP is the better name for this. Consequently NO_IOPORT is
> renamed to NO_IOPORT_MAP.
> 
> The motivation for this change is to reintroduce a symbol HAS_IOPORT
> that signals if outb/int et al are available. I will address that
> at least one merge window later though to keep surprises to a minimum
> and catch new introductions of (HAS|NO)_IOPORT.
> 
> The changes in this commit were done using:
> 
>         $ git grep -l -E '(NO|HAS)_IOPORT' | xargs perl -p -i -e 's/\b((?:CONFIG_)?(?:NO|HAS)_IOPORT)\b/$1_MAP/'
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks for taking up that work, I had a similar patch series
some years ago but never followed through with getting it upstream.
If there are no objections, I hope Andrew can queue it up for -mm.
Unfortunately I can't think of a good way to split up the patch
into smaller units that could go through subsystem maintainer
trees, since we want to start reusing the symbol as soon as possible.

Acked-by: Arnd Bergmann <arnd@arndb.de>

      reply	other threads:[~2014-02-20 15:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 23:56 [PATCH] rename HAS_IOPORT to HAS_IOPORT_MAP Uwe Kleine-König
2014-02-20 15:24 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201402201624.19922.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.