From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: x86_pmu_start WARN_ON.
Date: Thu, 20 Feb 2014 19:23:00 +0100 [thread overview]
Message-ID: <20140220182300.GN9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1402201302150.24360@vincent-weaver-1.um.maine.edu>
On Thu, Feb 20, 2014 at 01:03:16PM -0500, Vince Weaver wrote:
> attached, it's not very big.
This is I think the relevant bit:
pec_1076_warn-2804 [000] d... 147.926153: x86_pmu_disable: x86_pmu_disable
pec_1076_warn-2804 [000] d... 147.926153: x86_pmu_state: Events: {
pec_1076_warn-2804 [000] d... 147.926156: x86_pmu_state: 0: state: .R config: ffffffffffffffff ( (null))
pec_1076_warn-2804 [000] d... 147.926158: x86_pmu_state: 33: state: AR config: 0 (ffff88011ac99800)
pec_1076_warn-2804 [000] d... 147.926159: x86_pmu_state: }
pec_1076_warn-2804 [000] d... 147.926160: x86_pmu_state: n_events: 1, n_added: 0, n_txn: 1
pec_1076_warn-2804 [000] d... 147.926161: x86_pmu_state: Assignment: {
pec_1076_warn-2804 [000] d... 147.926162: x86_pmu_state: 0->33 tag: 1 config: 0 (ffff88011ac99800)
pec_1076_warn-2804 [000] d... 147.926163: x86_pmu_state: }
pec_1076_warn-2804 [000] d... 147.926166: collect_events: Adding event: 1 (ffff880119ec8800)
pec_1076_warn-2804 [000] d... 147.926170: collect_events: Adding event: 0 (ffff8800c9e01800)
pec_1076_warn-2804 [000] d... 147.926172: collect_events: Adding event: 4 (ffff8800cbab2c00)
pec_1076_warn-2804 [000] d... 147.926177: x86_pmu_enable: x86_pmu_enable
pec_1076_warn-2804 [000] d... 147.926177: x86_pmu_state: Events: {
pec_1076_warn-2804 [000] d... 147.926179: x86_pmu_state: 0: state: .R config: ffffffffffffffff ( (null))
pec_1076_warn-2804 [000] d... 147.926181: x86_pmu_state: 33: state: AR config: 0 (ffff88011ac99800)
pec_1076_warn-2804 [000] d... 147.926182: x86_pmu_state: }
pec_1076_warn-2804 [000] d... 147.926184: x86_pmu_state: n_events: 2, n_added: 2, n_txn: 2
pec_1076_warn-2804 [000] d... 147.926184: x86_pmu_state: Assignment: {
pec_1076_warn-2804 [000] d... 147.926186: x86_pmu_state: 0->33 tag: 1 config: 0 (ffff88011ac99800)
pec_1076_warn-2804 [000] d... 147.926188: x86_pmu_state: 1->0 tag: 1 config: 1 (ffff880119ec8800)
pec_1076_warn-2804 [000] d... 147.926188: x86_pmu_state: }
pec_1076_warn-2804 [000] d... 147.926190: x86_pmu_enable: S0: hwc->idx: 33, hwc->last_cpu: 0, hwc->last_tag: 1 hwc->state: 0
pec_1076_warn-2804 [000] d... 147.926191: x86_pmu_enable: starting: 0
so it does indeed look like n_added got scrambled; we started out with 1
event on disable; we've got 2 events on enable, but n_added is also 2,
which would suggest we had 0 on disable.
That makes us want to (re)start the NMI counter alright.
I've got to go run errands for a bit; hopefully I can find a bit of time
later tonight to look this over.
next prev parent reply other threads:[~2014-02-20 18:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 19:02 x86_pmu_start WARN_ON Dave Jones
2014-02-10 21:26 ` Vince Weaver
2014-02-11 13:29 ` Peter Zijlstra
2014-02-12 21:04 ` Vince Weaver
2014-02-13 14:11 ` Vince Weaver
2014-02-13 17:35 ` Vince Weaver
2014-02-13 22:13 ` Vince Weaver
2014-02-17 15:28 ` Peter Zijlstra
2014-02-18 18:30 ` Vince Weaver
2014-02-18 22:20 ` Vince Weaver
2014-02-19 10:19 ` Peter Zijlstra
2014-02-19 22:34 ` Vince Weaver
2014-02-20 10:08 ` Peter Zijlstra
2014-02-20 15:47 ` Andi Kleen
2014-02-20 15:54 ` Peter Zijlstra
2014-02-20 17:31 ` Andi Kleen
2014-02-20 18:15 ` Peter Zijlstra
2014-02-20 18:23 ` Andi Kleen
2014-02-20 19:04 ` Steven Rostedt
2014-02-20 16:26 ` Steven Rostedt
2014-02-20 17:00 ` Peter Zijlstra
2014-02-20 17:43 ` Steven Rostedt
2014-02-20 17:46 ` Steven Rostedt
2014-02-20 18:18 ` Peter Zijlstra
2014-02-20 18:03 ` Vince Weaver
2014-02-20 18:23 ` Peter Zijlstra [this message]
2014-02-20 18:54 ` Vince Weaver
2014-02-20 19:21 ` Vince Weaver
2014-02-20 19:46 ` Vince Weaver
2014-02-21 14:37 ` Vince Weaver
2014-02-21 15:03 ` Peter Zijlstra
2014-02-21 20:18 ` Vince Weaver
2014-02-24 11:28 ` Peter Zijlstra
2014-02-26 5:59 ` Vince Weaver
2014-02-27 13:32 ` [tip:perf/core] perf/x86: Fix event scheduling tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220182300.GN9987@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.