From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 05/13] drm: provide device-refcount Date: Fri, 21 Feb 2014 08:01:46 +0100 Message-ID: <20140221070144.GA22574@ulmo.nvidia.com> References: <1391004120-687-1-git-send-email-dh.herrmann@gmail.com> <1391004120-687-6-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0609392874==" Return-path: Received: from mail-bk0-f52.google.com (mail-bk0-f52.google.com [209.85.214.52]) by gabe.freedesktop.org (Postfix) with ESMTP id A7778FA63F for ; Thu, 20 Feb 2014 23:01:49 -0800 (PST) Received: by mail-bk0-f52.google.com with SMTP id e11so934087bkh.11 for ; Thu, 20 Feb 2014 23:01:48 -0800 (PST) In-Reply-To: <1391004120-687-6-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: David Herrmann Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0609392874== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 29, 2014 at 03:01:52PM +0100, David Herrmann wrote: [...] > diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c [...] > @@ -486,12 +490,10 @@ EXPORT_SYMBOL(drm_dev_alloc); > * @dev: DRM device to free > * > * Free a DRM device that has previously been allocated via drm_dev_alloc(). > - * You must not use kfree() instead or you will leak memory. > - * > - * This must not be called once the device got registered. Use drm_put_dev() > - * instead, which then calls drm_dev_free(). > + * This may not be called directly, you must use drm_dev_ref() and > + * drm_dev_unref() to gain and drop references to the object. > */ > -void drm_dev_free(struct drm_device *dev) > +static void drm_dev_free(struct drm_device *dev) With the function turning static it can't be called from anywhere else but this file, so perhaps the last sentence of the comment can now go away as well? Thierry --KsGdsel6WgEHnImy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTBvnYAAoJEN0jrNd/PrOhh84P/2GCCVl4q2O03YJOcUucwnZ9 qoBpNx3onMZ/FpWsqC1RWcPIVoe8J9ybQe4mVt8XvbIYQP2+tbC5nSYaSrxBEEQF ZKzO/re9fJTWSFlDypH6XwglEazicSPt7XJz2JnJX+P8SeVKUpSyrjDAumD04tOq UCQYiKhn1nxIt1WYZi+FbnEB0eWdAaLBGbAj56og9iS4VVka27AYgiCgJBa9Sd88 oi/jgrsuEDQR7VwDEUt9B5xk/8BE/UTYTsfqZoQ0D7CVI+Fv9LS1BoWtOWwXpUZf Wk5jPJtWvCpXCYUxMoTV5v4E0vgE92+vqgJMxukmHEdiJSUSYneropWYbn9YBmXu ngiufn+EpO3bbTqn91ArMuJHWE0hmR0dIwvt7nS2+Xac9w/owC6H+BnUXVIzO226 Fp54Wtm51OH08KrtgmEuhCZA6vUdONqgyGFIiUlmSAjfcp8OfsQhcGnRElIg8n5s VkQ6CLLlEZiLzmtpkTx7iFWZYaXiId2uSFEgtUsovOIGu1Fppgw+jSQRj2KAzm+7 vN//wmGNIeql1BDRlGBZSP5kOIQmto5xgirNVbgnIvE7/ES+XVV0D7J6UjqpaBu9 /wpYmTGe0qMP003+seweAZ8dafTCbQr/SXIxj4ThXvBhik/puasgkC9BJBOuqHk7 /akJLAh3wyGcHzpkekGD =apUF -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy-- --===============0609392874== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0609392874==--