From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 11/13] drm: remove redundant minor->device field Date: Fri, 21 Feb 2014 08:30:24 +0100 Message-ID: <20140221073022.GD22574@ulmo.nvidia.com> References: <1391004120-687-1-git-send-email-dh.herrmann@gmail.com> <1391004120-687-12-git-send-email-dh.herrmann@gmail.com> <20140212133624.GV17001@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1074973528==" Return-path: Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A3FE7FB294 for ; Thu, 20 Feb 2014 23:30:28 -0800 (PST) Received: by mail-bk0-f54.google.com with SMTP id w10so94274bkz.41 for ; Thu, 20 Feb 2014 23:30:27 -0800 (PST) In-Reply-To: <20140212133624.GV17001@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1074973528== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3Pql8miugIZX0722" Content-Disposition: inline --3Pql8miugIZX0722 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 12, 2014 at 02:36:24PM +0100, Daniel Vetter wrote: > On Wed, Jan 29, 2014 at 03:01:58PM +0100, David Herrmann wrote: > > Whenever we access minor->device, we are in a minor->kdev->...->fops > > callback so the minor->kdev pointer *must* be valid. Thus, simply use > > minor->kdev->devt instead of minor->device and remove the redundant fie= ld. > >=20 > > Signed-off-by: David Herrmann >=20 > I think this is simply compat cruft from the days when the drm core was > still shared with the *bsds. With the one patch I've commented on all > patches up to this one are >=20 > Reviewed-by: Daniel Vetter >=20 > As discussed on irc I think we don't want to have stable minor ids really, > userspace simply needs to inquire udev to get at the right > render/control/legacy node it wants. Does that mean we should go all the way and don't keep the +64 (for control) and +128 (for render nodes) offsets either? Should it be possible to have a /dev/dri directory that looks somewhat like this: /dev/dri/card0 (GPU#0, legacy) /dev/dri/card1 (GPU#1, legacy) /dev/dri/render0 (GPU#1, render) ? Thierry --3Pql8miugIZX0722 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTBwCOAAoJEN0jrNd/PrOhjCIQALqxidxF9rcqDJ07E140sBfc GZZ6cj9nCo7Ji6I7UXGIUjfZnMNlDAs7vcJSiyYEliq+HZqGjkG9mSV2W6pyjWvy +ndtwNCcb9M0SwBBLpKU6Z77wlNDJa03N2BG6dlx6IQebyDigwqjMZ52nZVbMnbe YHHrTjaz+SUZjAdq9MKDjX6vEyZ24+zG4ORRJeJZifeKoOk7uoj4ryaMenDntdwg uDqfbimoNozD/EOHccSJ9FCCBU4xmbidejwjTTjJTp9O6qCQR8tUhGqydsQE/mSR 5ft2MwBW0Tlet5ey/Ak2twLeb8dm30izjs3Qe5HhCkRMBj5gBAeCa4kQtmG46aNz 6khuFgeWYlPfU+UmdIYV1tHnY+UQFgG2Uka0y+Rw0gaDtk7aswFmt6S6wd1EiJg9 SqKTD/9J6q8FqO62lIYuQmQ1YSKEqfr1IVNPcC2jdVUitm9BCY26Pd0FD/izxreZ 3BWacxZ7YR8r3aBNhWPkqYtzW70vgP9Eb5QmKYtyG4/1rsKUNCR1C/0qj7cxDgGL 2S/chFdDwW/PMhjHERhzHn1oerHimRcEikenVrjkgLH/I24iCwhsIvxRPrZRB6U+ +/tEj9FPGD7b629TRZzKG2tvoxg7OEuQ/HHeo3dqdNuolbs9BK+i3zfkYb23X/6t r6qL1BACbq8J5CqaBxNa =GUoj -----END PGP SIGNATURE----- --3Pql8miugIZX0722-- --===============1074973528== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1074973528==--