Re: [PATCH net-next 4/6] 6lowpan: fix some checkpatch issues

[Alexander Aring <alex.aring@gmail.com>]

Hi,

On Fri, Feb 21, 2014 at 08:58:57AM -0800, Joe Perches wrote:
> On Fri, 2014-02-21 at 16:15 +0100, Alexander Aring wrote:
> > diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
> []
> > @@ -484,8 +475,8 @@ lowpan_skb_fragmentation(struct sk_buff *skb, struct net_device *dev)
> >  		err = lowpan_fragment_xmit(skb, head, header_length, len,
> >  					   offset, LOWPAN_DISPATCH_FRAGN);
> >  		if (err) {
> > -			pr_debug("%s unable to send a subsequent FRAGN packet "
> > -				 "(tag: %d, offset: %d", __func__, tag, offset);
> > +			pr_debug("%s unable to send a FRAGN packet.", __func__);
> > +			pr_debug("tag: %d, offset: %d", tag, offset);
> 
> No need for 2 pr_debug statements.
> 
> Better to coalesce the format pieces into a single string
> adding the close parenthesis and a terminating newline.
> 
> 			pr_debug("%s: unable to send a subsequent FRAGN packet "(tag: %d, offset: %d)\n",
> 				 __func__, tag, offset);
ah ok, thanks I will fix it.

- Alex