From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: [meta-qt5][PATCH 1/4] qmake5_base.bbclass: Use Qt version path for headers
Date: Fri, 21 Feb 2014 16:12:07 -0500 [thread overview]
Message-ID: <20140221211207.GW22890@denix.org> (raw)
In-Reply-To: <1393015264-8343-1-git-send-email-otavio@ossystems.com.br>
On Fri, Feb 21, 2014 at 05:41:01PM -0300, Otavio Salvador wrote:
> When looking for Qt5 headers we ought to use the Qt5 specific path. In
> case the distribution wants to have a flat tree it can set QT_DIR_NAME
> and it will still works as expected.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Acked-by: Denys Dmytriyenko <denys@ti.com>
Martin,
Thinking about what you said in that Wiki section - I believe the number of
apps consuming headers from /usr/include/qt5 is much higher than number of
non-Qt5 libs/modules potentially installing headers in there... So, we
shouldn't require every app recipe to set PATH_HEADERS properly.
> ---
> classes/qmake5_base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/qmake5_base.bbclass b/classes/qmake5_base.bbclass
> index 3861cd0..0cfb5a4 100644
> --- a/classes/qmake5_base.bbclass
> +++ b/classes/qmake5_base.bbclass
> @@ -57,7 +57,7 @@ do_generate_qt_config_file() {
> cat > ${QT_CONF_PATH} <<EOF
> [Paths]
> Prefix = ${OE_QMAKE_PATH_PREFIX}
> -Headers = ${OE_QMAKE_PATH_HEADERS}
> +Headers = ${OE_QMAKE_PATH_QT_HEADERS}
> Libraries = ${OE_QMAKE_PATH_LIBS}
> ArchData = ${OE_QMAKE_PATH_ARCHDATA}
> Data = ${OE_QMAKE_PATH_DATA}
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2014-02-21 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 20:41 [meta-qt5][PATCH 1/4] qmake5_base.bbclass: Use Qt version path for headers Otavio Salvador
2014-02-21 20:41 ` [meta-qt5][PATCH 2/4] mallit-framework-qt5: Don't set OE_QMAKE_PATH_HEADERS Otavio Salvador
2014-02-21 20:41 ` [meta-qt5][PATCH 3/4] mallit-plugins-qt5: " Otavio Salvador
2014-02-21 20:41 ` [meta-qt5][PATCH 4/4] qsiv: add the qsiv 1.1 example app Otavio Salvador
2014-02-21 21:12 ` Denys Dmytriyenko [this message]
2014-02-21 21:48 ` [meta-qt5][PATCH 1/4] qmake5_base.bbclass: Use Qt version path for headers Otavio Salvador
2014-02-22 6:37 ` Martin Jansa
2014-02-23 13:45 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221211207.GW22890@denix.org \
--to=denis@denix.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.