All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
Date: Fri, 21 Feb 2014 23:11:28 +0100	[thread overview]
Message-ID: <20140221221128.GA16700@free.fr> (raw)
In-Reply-To: <1391032104-18150-1-git-send-email-yann.morin.1998@free.fr>

All,

On 2014-01-29 22:48 +0100, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
>     $(TOPDIR)/local.mk
> 
> This works well for in-tree builds, but is not very useful for
> out-of-tree builds, when the Buildroot source tree may be shared for
> different concurrent builds.
> 
> Also, it seems to be more sensible to have local.mk alognside
> the .config file.
> 
> Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
>     $(CONFIG_DIR)/local.mk
> 
> Note that this does not change the current behaviour for in-tree
> builds, since in that case $(CONFIG_DIR) == $(TOPDIR).
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>

Ping? For -next?

Note that it was acked by Arnout.

> ---
>  Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Config.in b/Config.in
> index 7ec7c2a..f8d6e23 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
>  
>  config BR2_PACKAGE_OVERRIDE_FILE
>  	string "location of a package override file"
> -	default "$(TOPDIR)/local.mk"
> +	default "$(CONFIG_DIR)/local.mk"
>  	help
>  	  A package override file is a short makefile that contains
>  	  variable definitions of the form <pkg>_OVERRIDE_SRCDIR,

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2014-02-21 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 21:48 [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk Yann E. MORIN
2014-01-30  7:05 ` Arnout Vandecappelle
2014-02-21 22:11 ` Yann E. MORIN [this message]
2014-02-21 22:31   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2014-01-29 18:42 Yann E. MORIN
2014-01-29 20:45 ` Thomas De Schampheleire
2014-01-29 20:59   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140221221128.GA16700@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.