All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] sdl: run autogen.sh as PRE_CONFIGURE step
Date: Sat, 22 Feb 2014 18:12:20 +0100	[thread overview]
Message-ID: <20140222181220.134dc547@skate> (raw)
In-Reply-To: <1393063090-831-1-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Sat, 22 Feb 2014 10:58:10 +0100, Romain Naour wrote:
> For the same reason as for the gpm package:
> 
> "Move the GPM_RUN_AUTOGEN to be a PRE_CONFIGURE step because this step
> depends on the dependancies being built. If it is a POST_PATCH step
> the dependencies won't be built and the GPM_RUN_AUTOGEN step will fail
> (if the host doesn't have autotools)"
> -- Ryan Barnett
> 
> Fixes:
> http://autobuild.buildroot.net/results/543/543b4135c7996133f32e82d72d6f2969622f8617/build-end.log
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/sdl/sdl.mk | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index ba5fbca..ad3e19d 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -12,15 +12,14 @@ SDL_LICENSE_FILES = COPYING
>  SDL_INSTALL_STAGING = YES
>  
>  # we're patching configure.in, but package cannot autoreconf with our version of
> -# autotools, so we have to do it manually instead of setting SD_AUTORECONF = YES
> +# autotools, so we have to do it manually instead of setting SDL_AUTORECONF = YES
>  define SDL_RUN_AUTOGEN
>  	cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh
>  endef
>  
> -SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN
> +SDL_PRE_CONFIGURE_HOOKS += SDL_RUN_AUTOGEN
>  SDL_DEPENDENCIES += host-automake host-autoconf host-libtool

A similar change was made (but for a different reason) in the next
branch, in commit
http://git.buildroot.net/buildroot/commit/package/sdl?h=next&id=f75b5de9f6f473a257c607e97419a2338d57333c.

Peter, we should backport this patch into the master branch, I believe.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-02-22 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-22  9:58 [Buildroot] [PATCH 1/1] sdl: run autogen.sh as PRE_CONFIGURE step Romain Naour
2014-02-22 17:12 ` Thomas Petazzoni [this message]
2014-02-22 18:32   ` Romain Naour
2014-02-22 20:19     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140222181220.134dc547@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.