From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax
Date: Sun, 23 Feb 2014 18:42:21 +0100 [thread overview]
Message-ID: <20140223184221.2649dcb1@skate> (raw)
In-Reply-To: <1393176587-27407-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 23 Feb 2014 18:29:47 +0100, Yann E. MORIN wrote:
> diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
> index ff4284e..605635c 100644
> --- a/package/rt-tests/Config.in
> +++ b/package/rt-tests/Config.in
> @@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS
> # no NPTL for these archs
> depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
> # no _tid field in 'struct sigevent'
> - depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
> - BR2_mips64 || BR2_mips64el)
> + depends on ! ( BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
> + BR2_mips64 || BR2_mips64el) )
I know it's nitpicking, but I must say I personally dislike these
spaces between !, parenthesis and the rest. I very much prefer:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
BR2_mips64 || BR2_mips64el))
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-23 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 17:29 [Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax Yann E. MORIN
2014-02-23 17:42 ` Thomas Petazzoni [this message]
2014-02-23 17:54 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223184221.2649dcb1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.