All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/mysql: fix debugging options
Date: Sun, 23 Feb 2014 20:12:28 +0100	[thread overview]
Message-ID: <20140223191228.GG32759@free.fr> (raw)
In-Reply-To: <1392244774-15356-2-git-send-email-kuyurix@gmail.com>

Marcello, All,

On 2014-02-12 22:39 +0000, Marcelo Guti?rrez spake thusly:
> From: Marcelo Gutierrez <kuyurix@gmail.com>
> 
> The usual --{en,dis}able-debug passed by the infrastructure are not
> recognised by mysql's ./configure, as it uses unusual options.
> 
> Also, debugging is only meaningfull to the server, not the client.
> 
> Signed-off-by: Marcelo Gutierrez (UTN/FRH) <kuyurix@gmail.com>
> [yann.morin.1998 at free.fr: actually add the options, move in server if-block]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Arnout Vandecappelle <arnout@mind.be>

Obviously, this already has my SoB-line.

So this is just a reminder for Peter. ;-)

Regards,
Yann E. MORIN.

> ---
>  package/mysql/mysql.mk |   11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/package/mysql/mysql.mk b/package/mysql/mysql.mk
> index 27afc9f..95b30b7 100644
> --- a/package/mysql/mysql.mk
> +++ b/package/mysql/mysql.mk
> @@ -30,8 +30,7 @@ MYSQL_CONF_OPT = \
>  	--without-libedit \
>  	--without-readline \
>  	--with-low-memory \
> -	--enable-thread-safe-client \
> -	$(ENABLE_DEBUG)
> +	--enable-thread-safe-client
>  
>  ifeq ($(BR2_PACKAGE_MYSQL_SERVER),y)
>  MYSQL_DEPENDENCIES += host-mysql host-bison
> @@ -57,6 +56,14 @@ MYSQL_CONF_OPT += \
>  	--without-plugin-innodb_plugin \
>  	--without-plugin-ndbcluster
>  
> +# Debugging is only available for the server, so no need for
> +# this if-block outside of the server if-block
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +MYSQL_CONF_OPT += --with-debug=full
> +else
> +MYSQL_CONF_OPT += --without-debug
> +endif
> +
>  define HOST_MYSQL_BUILD_CMDS
>  	$(MAKE) -C $(@D)/include my_config.h
>  	$(MAKE) -C $(@D)/mysys libmysys.a
> -- 
> 1.7.9.5
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-02-23 19:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 22:39 [Buildroot] [PATCH 1/2] mysql: add option to build the server Marcelo Gutiérrez
2014-02-12 22:39 ` [Buildroot] [PATCH 2/2] package/mysql: fix debugging options Marcelo Gutiérrez
2014-02-23 19:12   ` Yann E. MORIN [this message]
2014-02-23 19:10 ` [Buildroot] [PATCH 1/2] mysql: add option to build the server Yann E. MORIN
2014-02-23 20:15 ` Peter Korsgaard
2014-02-24 19:38   ` Marcelo Gutierrez
2014-03-03 22:35 ` Thomas Petazzoni
2014-03-04  2:39   ` Marcelo Gutierrez
2014-03-04  5:51     ` Baruch Siach
2014-03-04 17:53       ` Marcelo Gutierrez
  -- strict thread matches above, loose matches on Subject: below --
2014-02-04 15:41 [Buildroot] [PATCH 0/2] MySQL debug fix, and Mysql server on target Yann E. MORIN
2014-02-04 15:41 ` [Buildroot] [PATCH 2/2] package/mysql: fix debugging options Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140223191228.GG32759@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.