All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: add support for flink
Date: Mon, 24 Feb 2014 08:06:17 +1100	[thread overview]
Message-ID: <20140223210617.GC4317@dastard> (raw)
In-Reply-To: <20140221004933.GA9445@infradead.org>

On Thu, Feb 20, 2014 at 04:49:33PM -0800, Christoph Hellwig wrote:
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
.....
> +static cmdinfo_t flink_cmd;
> +
> +static void
> +flink_help(void)
> +{
> +	printf(_(
> +"\n"
> +"link the open file descriptor into the filesystem\n"
> +"\n"
> +"\n"));
> +}

"link the open file descriptor to the supplied filename\n"

?

> +void
> +flink_init(void)
> +{
> +	flink_cmd.name = "flink";
> +	flink_cmd.cfunc = flink_f;
> +	flink_cmd.argmin = 1;
> +	flink_cmd.argmax = 1;
> +	flink_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> +	flink_cmd.args = _("filename");
> +	flink_cmd.oneline =
> +		_("link the open file descriptor into the filesystem");
> +	flink_cmd.help = flink_help;
> +
> +	add_command(&flink_cmd);
> +}
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index 7a92ff6..7d0c792 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -638,6 +638,9 @@ Only available in expert mode and requires privileges.
>  Undo the effects of a filesystem freeze operation.
>  Only available in expert mode and requires privileges.
>  .TP
> +.B flink		
> +Link the currently open file descriptor into the filesystem namespace.
> +.TP

And that needs to indicate that a filename needs to be provided,
too.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-23 21:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 22:00 [PATCH] xfs_io: add support for O_TMPFILE opens Christoph Hellwig
2014-02-20 22:15 ` Dave Chinner
2014-02-20 22:40   ` Christoph Hellwig
2014-02-21  0:16 ` Shaun Gosse
2014-02-21  0:20   ` Christoph Hellwig
2014-02-21  0:30 ` [PATCH v2] " Christoph Hellwig
2014-02-23 21:01   ` Dave Chinner
2014-02-21  0:49 ` [PATCH] xfs_io: add support for flink Christoph Hellwig
2014-02-23 21:06   ` Dave Chinner [this message]
2014-02-25 19:52   ` [PATCH v2] " Christoph Hellwig
2014-02-25 23:35     ` Dave Chinner
2014-03-13 10:09       ` Christoph Hellwig
2014-03-13 10:21         ` Dave Chinner
2014-03-13 10:42           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140223210617.GC4317@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.