From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHjsW-0001CP-9m for qemu-devel@nongnu.org; Sun, 23 Feb 2014 19:58:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHjsQ-0006Sm-Sl for qemu-devel@nongnu.org; Sun, 23 Feb 2014 19:58:40 -0500 Received: from mail-oa0-x235.google.com ([2607:f8b0:4003:c02::235]:54271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHjsQ-0006Sg-NC for qemu-devel@nongnu.org; Sun, 23 Feb 2014 19:58:34 -0500 Received: by mail-oa0-f53.google.com with SMTP id o6so1280021oag.26 for ; Sun, 23 Feb 2014 16:58:33 -0800 (PST) Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20140113172514.11163.75410.stgit@helix> References: <20140113172514.11163.75410.stgit@helix> Message-ID: <20140224005829.3593.28883@loki> Date: Sun, 23 Feb 2014 18:58:29 -0600 Subject: Re: [Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama , qemu-devel@nongnu.org Cc: ghammer@redhat.com, lcapitulino@redhat.com, mitsuhiro.tanino@hds.com, rhod@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com Quoting Tomoki Sekiyama (2014-01-13 11:25:14) > Current functionarity of qemu-ga VSS provider is limited to implement > filesystems freeze, and doesn't support the creation of shadow copies > within the guest. > However, when no other hardware snapshot provider is installed, VSS may > choose qemu-ga VSS provider to create shadow copies and fail with > VSS_E_UNEXPECTED_PROVIDER_ERROR. > Similar issue occurs when the requester deletes shadow copies. > = > This patchset fix this issue by telling VSS that the volume is not > supported by qemu-ga VSS provider when it is kicked by other requesters. > = > It also fixes wrong error handling around OpenEvent/CreateEvent WinAPI, > which returns NULL instead of INVALID_HANDLE_VALUE on errors. > = > https://bugzilla.redhat.com/show_bug.cgi?id=3D1036341 > = > --- > Tomoki Sekiyama (3): > qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and Cr= eateEvent > qga: vss-win32: Fix interference with snapshot creation by other VS= S requesters > qga: vss-win32: Fix interference with snapshot deletion by other VS= S request Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga = > = > = > qga/vss-win32/provider.cpp | 21 ++++++++++--- > qga/vss-win32/requester.cpp | 70 ++++++++++++++++++++-----------------= ------ > 2 files changed, 49 insertions(+), 42 deletions(-) > = > -- = > Tomoki Sekiyama