From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org,
ufimtseva@gmail.com
Subject: Re: [PATCH] staging: ced401: remove redundant spin_unlock
Date: Mon, 24 Feb 2014 11:06:56 +0300 [thread overview]
Message-ID: <20140224080656.GC26722@mwanda> (raw)
In-Reply-To: <3750536.lQYs9UcrV9@daeseok-laptop.cloud.net>
On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Mon, 24 Feb 2014 09:17:41 +0900
> Subject: [PATCH] staging: ced401: remove redundant spin_unlock
Don't send this header. We get everything from the email header.
>
> sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
> context imbalance in 'Handle1401Esc' - unexpected unlock
>
Your fix is correct, but the changelog is not good. These messages in
Sparse are wrong over 80% of the time. So when I see one in a commit
message I assume it is wrong. Add some more explanation to say why you
removed the spin_unlock.
Also "redundant" means "unnecessary" but sort of implies that it is
harmless. Say something like: "staging: ced401: fix double unlock bug".
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-24 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 0:51 [PATCH] staging: ced401: remove redundant spin_unlock Daeseok Youn
2014-02-24 8:06 ` Dan Carpenter [this message]
2014-02-24 9:44 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224080656.GC26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=ufimtseva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.